Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: get all project config from global const #393

Merged
merged 325 commits into from
Jan 20, 2025
Merged

Conversation

groninge01
Copy link
Contributor

@groninge01 groninge01 commented Dec 30, 2024

put all project config related variables in the config file

one issue is that for cow in the pool filter only the category "Incentivized" returns pools so the other categories don't make sense
this could be resolved by giving cow it's own app & config

@agualis agualis self-requested a review January 17, 2025 11:08
Copy link
Collaborator

@agualis agualis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only blocker would be the CoW AMM filter issue. I don't fully understand why it is not possible to keep the same logic.

@groninge01
Copy link
Contributor Author

The only blocker would be the CoW AMM filter issue. I don't fully understand why it is not possible to keep the same logic.

also for @garethfuller
i think i can just leave it as is for now?

Copy link
Contributor

@garethfuller garethfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this removes the description work I did last week? Unless it's just not been merged in?
Screenshot 2025-01-20 at 13 59 45

@groninge01
Copy link
Contributor Author

groninge01 commented Jan 20, 2025

Somehow this removes the description work I did last week? Unless it's just not been merged in? Screenshot 2025-01-20 at 13 59 45

that was not merged from main yet, had a conflict so it's merged in now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants