feat: add hook tag on pools list #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
garethfuller
previously requested changes
Nov 28, 2024
Comment on lines
9
to
13
| export function useHook({ | ||
| hook, | ||
| poolTokens, | ||
| chain, | ||
| }: { |
There was a problem hiding this comment.
Please revert to just pass in the pool. It's more verbose in all the components you need to use this hook or the hook tag component otherwise. If you did it because of the different pool types between the detail and list then just set the prop style as Pool | PoolListItem, it should work.
There was a problem hiding this comment.
There are different pool types in pools vs pool query, that's why decided to pass just properties
There was a problem hiding this comment.
Yeah, like I said, can you not just use the type Pool | PoolListItem?
agualis
requested changes
Dec 3, 2024
packages/lib/modules/pool/PoolList/PoolListTable/PoolListTableRow.tsx
Outdated
Show resolved
Hide resolved
agualis
approved these changes
Dec 3, 2024
agualis
dismissed
garethfuller’s stale review
Changes done and reviewed by agualis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds hook tag on pools list
