Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing our new permissionless
FXPoolDeployer
, which will replace the olderFXPoolFactory
Using the new
FXPoolDeployer
, we don't have to maintain a hardcoded list of oracle aggregator addresses anymore. Every time a pool is created, we simply fetch the aggregator address fromFXPool.assimilator() -> Assimilator.oracle() -> Oracle.aggregator()
. This isn't possible with the olderFXPoolFactory
because the pool needs to be initialized first before the assimilator is attached to the pool, which happens afterNewFXPool
event.Other changes
Type of change
How should this be tested?
We've deployed the changes over to our balancer subgraph mainnet clone (trimmed down version):
https://thegraph.com/hosted-service/subgraph/xave-finance/balancer-v2
Simply run the "Query FXPools" from the query dropdown and it should return:
Checklist:
dev
->master
Merges to
dev