Feat/port sor #77
Merged
Feat/port sor #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmbronco
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Nice one! I'm glad we move this part to the API. What do you think about changing the folder the SOR is in right now to something more integrated, eg: /modules/sor/lib? I'm thinking as well about setting proper boundaries / interfaces around it, so it can be worked with independently from the service, potentially making it easy to add different implementations. It's not a big effort now, but might be a bigger one once we start to mix it into other parts of the codebase, eg: types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #59