SOR - Assert behavior for tokens with 0 decimals #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4821240 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mkflow27
approved these changes
Jan 17, 2025
| tOut = new Token(parseFloat(chainToIdMap['GNOSIS']), MPS.address as Address, MPS.token.decimals); | ||
| }); | ||
|
|
||
| test('SOR quote should match swap query - below min', async () => { |
There was a problem hiding this comment.
Based on the issue description this is the test which ensures there is no issue in the sdk.
| @@ -10,7 +10,8 @@ | |||
| "resolveJsonModule": true, | |||
| "outDir": "./dist", | |||
| "skipLibCheck": true, | |||
| "sourceMap": true | |||
| "sourceMap": true, | |||
| "types": ["vitest/globals"], | |||
There was a problem hiding this comment.
Makes working with tests easier.
johngrantuk
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #795