feat: support ak/sk auth #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ZingLix
commented
Feb 7, 2024
ZingLix
commented
- Description: 支持应用 aksk 鉴权
- Issue: golang release 0.0.2 #260
- Dependencies: /
- Tag maintainer: @stonekim, @danielhjz, @Dobiichi-Origami.
|
|
||
| var _authManager *AuthManager | ||
|
|
||
| func GetAuthManager() *AuthManager { |
There was a problem hiding this comment.
有没有场景，AuthManager 的 Requestor 需要一些特殊设置?
There was a problem hiding this comment.
貌似没有，python目前没遇到，需要设置的参数都走GetConfig()获取
| func (s *ModelResponseStream) checkResponseError() error { | ||
| tokenRefreshed := false | ||
| var apiError *APIError | ||
| for retryCount := 0; retryCount < s.Options.LLMRetryCount || s.Options.LLMRetryCount == 0; retryCount++ { |
There was a problem hiding this comment.
s.Options.LLMRetryCount == 0 这个重试条件建议注释一下，不然看的有点吓人
go/qianfan/base_model.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if err = checkResponseError(modelApiResponse); err != nil { |
There was a problem hiding this comment.
圈复杂度有些高了，解下。看起来有点头晕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.