-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add id token support #169
base: main
Are you sure you want to change the base?
Conversation
Hey, I've rejected a very similar PR in the past, #118 But I've actually changed my mind since then. I still don't intend to turn this in a full-blown OIDC library, but this seems like a fairly low-lift way for people to just get the idToken and potentially do the JWT parsing themselves, so well... lets do it I guess. However, I have notes:
|
Per https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1 the parameters first need to be url encoded.
Hi @evert Thanks for your feedback. I think adding ID Token won't hurt this lib, since most if not all modern Oauth2 providers DO support OIDC ☝️ . In fact, I also own an OIDC/Oauth2 provider which returns ID token by default 🤗 Providing an ID token saves Frontend from making at least 1 extra call to the provider endpoint to get a UPD: I fixed my code as per your feedback and added a test. For some reason, current |
There's lots of OAuth2 use-cases. You don't really see this as much for example when OAuth2 is used to integrate with APIs of commercial software, and frankly OIDC is overkill for many cases. If you can, try to undo those formatting changes as they are causing a conflict, and will also down the road cause a conflict with #172 which is also actively being worked on! |
Restored original formatting. Added a test for |
There's still a conflict and some changes unrelated to this PR! Once those are fix, this is good to merge, thanks! |
No description provided.