feat(egh): Course Creation Sync Flow #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Creeland <[email protected]>
- Introduced a new event for course creation: `EGGHEAD_COURSE_CREATED_EVENT`. - Added type definition for `EggheadCourseCreated` and its associated schema using Zod for validation. - Updated the event types in `inngest.server.ts` to include the new course created event. Co-authored-by: Creeland <[email protected]>
…dDbCourseSchema - Changed the `id` field in `EggheadDbCourseSchema` from optional to required. - Introduced a new `InstructorDbSchema` with comprehensive fields for instructor details, including `user_id`, `email`, and various optional attributes. - Updated the `loadEggheadInstructorForUser` function to validate the instructor data using the new schema, ensuring robust error handling. Co-authored-by: Creeland <[email protected]>
- Added the `createCourseInEgghead` function to handle course creation in Egghead. - Integrated error handling for instructor retrieval and course creation. - Emitted `EGGHEAD_COURSE_CREATED_EVENT` upon successful course creation. - Updated the database to sync the created course ID with the corresponding post. This enhancement improves the workflow for creating courses and ensures proper event handling and data synchronization. Co-authored-by: Creeland <[email protected]>
- Imported `EGGHEAD_COURSE_CREATED_EVENT` to wait for course creation events from Egghead. - Implemented error handling to throw a `NonRetriableError` if the course is not created. - Mapped the `railsCourseId` to the newly created course ID and updated the `sharedId` to use the course's slug. - Improved the overall workflow for course creation in Sanity by ensuring proper event synchronization. Co-authored-by: Creeland <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joelhooks
approved these changes
Dec 17, 2024
| throw new NonRetriableError('Post not found') | ||
| } | ||
|
|
||
| if (post.fields?.postType !== 'course') { |
There was a problem hiding this comment.
this could be part of the trigger instead of here which imo makes more sense than throwing errors when any other kind of post is created
| const instructor = await loadEggheadInstructorForUser(post.createdById) | ||
|
|
||
| if (!instructor) { | ||
| return null |
There was a problem hiding this comment.
this could throw the error instead of returning null and probably remove the need for the guard below
| return course | ||
| }) | ||
|
|
||
| step.sendEvent(EGGHEAD_COURSE_CREATED_EVENT, { |
There was a problem hiding this comment.
kind of weird to go through all of the above and then send this different event 🤔
| }) | ||
| } | ||
|
|
||
| const course = await step.run('create-course', async () => { |
There was a problem hiding this comment.
insider. among this eggheadCourse instead of just course because so many courses
| @@ -39,22 +40,38 @@ export const createCourseInSanity = inngest.createFunction( | |||
| return contributor | |||
| }) | |||
|
|
|||
| const courseCreatedEvent = await step.waitForEvent( | |||
There was a problem hiding this comment.
i'm not super stoked about the way these are connected together and think we might consider tightening it up or making the flow more obvious
this is the danger of event driven
entropy
| @@ -40,6 +40,36 @@ export const getCachedEggheadInstructorForUser = unstable_cache( | |||
| { revalidate: 3600, tags: ['users'] }, | |||
| ) | |||
|
|
|||
| export const InstructorDbSchema = z.object({ | |||
There was a problem hiding this comment.
is the db here egghead? let's label it if so
kodiakhq
bot
deleted the
zac/egg-394-sync-courses-creation-to-rails-and-sanity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the course creation workflow that syncs courses between builder, egghead-rails, and sanity:
egghead/course-createdevent and handlerCo-authored-by: Creeland [email protected]