feat(EW): reproduce original navigation #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ltclmbdev
commented
Jun 18, 2024
| @@ -0,0 +1,39 @@ | |||
| 'use client' | |||
There was a problem hiding this comment.
converted this component to the "client" because we need framer-motion here (for animation when sale banner appears above, not implemented yet)
ltclmbdev
commented
Jun 18, 2024
|
|
||
| import { ThemeToggle } from './theme-toggle' | ||
|
|
||
| export const getNavigationLinks = (): { | ||
| export const useNavigationLinks = (): { |
There was a problem hiding this comment.
renamed to the useNaviagtionLinks to be able to use hooks inside
ltclmbdev
commented
Jun 18, 2024
| setHasMounted(true) | ||
| }, []) | ||
|
|
||
| const getTheme = (theme: string | undefined): 'light' | 'dark' => { |
There was a problem hiding this comment.
a bit of overhead to get the theme value here just to appease the typescript
ltclmbdev
commented
Jun 18, 2024
| @@ -0,0 +1,342 @@ | |||
| import { useId } from 'react' | |||
There was a problem hiding this comment.
use it for unique id's inside svgs because we have two instances of each icons and values should be unique to get icons rendered properly
ltclmbdev
added
the
WIP
ltclmbdev
removed
the
WIP
ltclmbdev
commented
Jun 21, 2024
| import { cn } from '@/utils/cn' | ||
|
|
||
| // import { SearchIcon } from '@heroicons/react/outline' | ||
| // import { useSearchBar } from 'search-bar/use-search-bar' |
There was a problem hiding this comment.
Not implemented yet
vojtaholik
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces the Naviagtion Footer components from original EW:
Desktop nav
Mobile nav
Footer