Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifies two or more columns, separated by commas. column_list must be enclosed in parentheses. Unless language_term is specified, the language of all columns of column_list must be the same.
Issues
Previously in Babelfish the support for multiple columns was unsupported for simple terms in contains clause and it gave syntax error.
Changes made to fix the issue
To resolve this issue we created a new grammar
var_name_list
andopt_var_name_list
to support the list of columns passed in the TSQL query.We also modified the grammar for single column to pass it as a list
opt_var_name
to bring singularity in the way both the column name and column list are being passed into the backend parser.Task: BABEL-4239
Authored-by: Jaspal Singh [email protected]
Signed-off-by: Jaspal Singh [email protected]
Issues Resolved
BABEL-4239
Extension side PR link: Support column_list in CONTAINS #3438
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.