Fixed error code difference occurring due to parallel worker enforced #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…babelfish-for-postgresql#260) When any error raised from parallel worker then Postgres by default does not share message_id (part of edata) to leader worker. Babelfish's error mapping framework relies on message_id to map to correct T-SQL error code. But since it is no more available to leader worker, T-SQL error code would not be found and default error code will be used. This will also affect the transactional behaviour of given error. In order to fix this issue, we need to store if given worker is spawned in the context of Babelfish or not to share error message_id. Hence, this changes made changes in two data structure namely Port and FixedParallelState to store context about Babelfish Extension changes: babelfish-for-postgresql/babelfish_extensions#2047 Task: BABEL-4539 Signed-off-by: Dipesh Dhameliya <[email protected]>
Merged
1 task
surendravishnoi
approved these changes
Dec 19, 2023
Deepesh125
merged commit 354bdde
into
babelfish-for-postgresql:BABEL_2_X_DEV__PG_14_X
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any error raised from parallel worker then Postgres by default does not share message_id (part of edata) to leader worker. Babelfish's error mapping framework relies on message_id to map to correct T-SQL error code. But since it is no more available to leader worker, T-SQL error code would not be found and default error code will be used. This will also affect the transactional behaviour of given error.
In order to fix this issue, we need to store if given worker is spawned in the context of Babelfish or not to share error message_id. Hence, this changes made changes in two data structure namely Port and FixedParallelState to store context about Babelfish
Extension changes: babelfish-for-postgresql/babelfish_extensions#2155
Task: BABEL-4539
Signed-off-by: Dipesh Dhameliya [email protected]
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.