Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed parallel qp test expected file after 556f7b7bc1 from community #3445

Conversation

lejaokri
Copy link
Contributor

@lejaokri lejaokri commented Feb 1, 2025

Description

Also fixed some testcase diff due to ordering because of parallel execution. Confirmed the plans are different.

-- non-Parallel
+~~START~~
+text
+Query Text: SELECT CAST('1' AS CHAR(10)) AS Col1
+UNION ALL
+SELECT NULL AS Col1
+GROUP BY Col1
+Append  (cost=0.00..0.03 rows=2 width=32) (actual time=0.002..0.005 rows=2 loops=1)
+  ->  Result  (cost=0.00..0.01 rows=1 width=32) (actual time=0.001..0.001 rows=1 loops=1)
+  ->  Group  (cost=0.00..0.01 rows=1 width=32) (actual time=0.002..0.002 rows=1 loops=1)
+        ->  Result  (cost=0.00..0.01 rows=1 width=0) (actual time=0.000..0.000 rows=1 loops=1)
+Planning Time: 0.131 ms
+Execution Time: 0.069 ms
+~~END~~
+
+~~START~~
+text
+Babelfish T-SQL Batch Parsing Time: 21.772 ms
+~~END~~
+
+
+SET BABELFISH_STATISTICS PROFILE OFF;
+GO

-- Parallel

+~~START~~
+text
+Query Text: SELECT CAST('1' AS CHAR(10)) AS Col1
+UNION ALL
+SELECT NULL AS Col1
+GROUP BY Col1
+Gather  (cost=0.00..0.01 rows=2 width=32) (actual time=0.003..0.006 rows=2 loops=1)
+  Workers Planned: 2
+  Workers Launched: 0
+  ->  Parallel Append  (cost=0.00..0.01 rows=1 width=32) (actual time=0.003..0.005 rows=2 loops=1)
+        ->  Group  (cost=0.00..0.01 rows=1 width=32) (actual time=0.002..0.003 rows=1 loops=1)
+              ->  Result  (cost=0.00..0.01 rows=1 width=0) (actual time=0.001..0.001 rows=1 loops=1)
+        ->  Result  (cost=0.00..0.01 rows=1 width=32) (actual time=0.000..0.001 rows=1 loops=1)
+Planning Time: 0.136 ms
+Execution Time: 0.072 ms
+~~END~~
+
+~~START~~
+text
+Babelfish T-SQL Batch Parsing Time: 22.117 ms
+~~END~~
+
+
+SET BABELFISH_STATISTICS PROFILE OFF;
+GO

Issues Resolved

[List any issues this PR will resolve]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13084287573

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 73.837%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_money/fixeddecimal.c 4 69.78%
Totals Coverage Status
Change from base Build 12925077568: -0.007%
Covered Lines: 43330
Relevant Lines: 58683

💛 - Coveralls

@shardgupta shardgupta merged commit ffbbfbd into babelfish-for-postgresql:BABEL_3_X_DEV Feb 3, 2025
43 checks passed
@shardgupta shardgupta deleted the klejao-BABEL_3_X_DEV__PG_15_X branch February 3, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants