-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for trigger FK reference fix on table/temp variables #3440
Merged
Deepesh125
merged 8 commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
amazon-aurora:JIRA-BABEL-5270
Feb 7, 2025
Merged
Add tests for trigger FK reference fix on table/temp variables #3440
Deepesh125
merged 8 commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
amazon-aurora:JIRA-BABEL-5270
Feb 7, 2025
+1,381
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]>
1 task
tanscorpio7
suggested changes
Jan 30, 2025
Pull Request Test Coverage Report for Build 13141819538Details
💛 - Coveralls |
Deepesh125
requested changes
Jan 30, 2025
tanscorpio7
approved these changes
Feb 4, 2025
Deepesh125
approved these changes
Feb 7, 2025
3c342e3
into
babelfish-for-postgresql:BABEL_5_X_DEV
46 checks passed
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Feb 7, 2025
…fish-for-postgresql#3440) This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]> (cherry picked from commit 3c342e3)
1 task
shardgupta
pushed a commit
that referenced
this pull request
Feb 7, 2025
#3463) This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]> (cherry picked from commit 3c342e3)
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Feb 7, 2025
…fish-for-postgresql#3440) This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]> (cherry picked from commit 3c342e3)
1 task
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Feb 7, 2025
…fish-for-postgresql#3440) (babelfish-for-postgresql#3463) This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]> (cherry picked from commit 3c342e3) (cherry picked from commit e2ac7f8)
rishabhtanwar29
pushed a commit
that referenced
this pull request
Feb 7, 2025
#3463) (#3469) This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]>
rishabhtanwar29
pushed a commit
that referenced
this pull request
Feb 7, 2025
#3467) * Add tests for trigger FK reference fix on table/temp variables (#3440) This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables. Task: BABEL-5270 Signed-off-by: Roshan Kanwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables.
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#522
Issues Resolved
Task: BABEL-5270
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.