Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for trigger FK reference fix on table/temp variables #3440

Conversation

roshan0708
Copy link
Contributor

@roshan0708 roshan0708 commented Jan 30, 2025

Description

This commit adds test cases to validate the fix for trigger failures with foreign key references on table variables and temp tables.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#522

Issues Resolved

Task: BABEL-5270

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13141819538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 74.978%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 76.03%
Totals Coverage Status
Change from base Build 13110163021: -0.004%
Covered Lines: 47079
Relevant Lines: 62790

💛 - Coveralls

@Deepesh125 Deepesh125 merged commit 3c342e3 into babelfish-for-postgresql:BABEL_5_X_DEV Feb 7, 2025
46 checks passed
@Deepesh125 Deepesh125 deleted the JIRA-BABEL-5270 branch February 7, 2025 05:43
roshan0708 added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Feb 7, 2025
…fish-for-postgresql#3440)

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
(cherry picked from commit 3c342e3)
shardgupta pushed a commit that referenced this pull request Feb 7, 2025
#3463)

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
(cherry picked from commit 3c342e3)
roshan0708 added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Feb 7, 2025
…fish-for-postgresql#3440)

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
(cherry picked from commit 3c342e3)
roshan0708 added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Feb 7, 2025
…fish-for-postgresql#3440) (babelfish-for-postgresql#3463)

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
(cherry picked from commit 3c342e3)
(cherry picked from commit e2ac7f8)
rishabhtanwar29 pushed a commit that referenced this pull request Feb 7, 2025
#3463) (#3469)

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
rishabhtanwar29 pushed a commit that referenced this pull request Feb 7, 2025
#3467)

* Add tests for trigger FK reference fix on table/temp variables (#3440)

This commit adds test cases to validate the fix for trigger failures
with foreign key references on table variables and temp tables.

Task: BABEL-5270
Signed-off-by: Roshan Kanwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants