Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version based connection reset using queries #3423

Open
wants to merge 111 commits into
base: BABEL_5_X_DEV
Choose a base branch
from

Conversation

SiddharthBITS
Copy link
Contributor

@SiddharthBITS SiddharthBITS commented Jan 22, 2025

Description

Resetting connection after each test instead of closing for versions > 16.6. Also disabling pg_hint for tests that left it open, as the enabled pg_hint setting leaks into other tests when resetting connections.

We can expect 5-6 mins of improvements for version upgrade tests with base > 16.6 and dump-restore tests. For other version upgrade tests these improvements are around 2-3 mins.

Key changes:

  • Implemented connection reset for SQL servers (versions > 16.6) post-test.
  • Replaced redundant 'isUpgradeTestMode' config variable with 'allowConnectionReset'.
  • Eliminated dependency on GitHub Actions workflows to ensure consistent test behavior across environments.
  • Optimized test execution to reduce overall completion time.

Task:
Signed-off-by: Siddharth Sengar [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request,
I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2025

Pull Request Test Coverage Report for Build 13061803500

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 74.985%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 76.03%
Totals Coverage Status
Change from base Build 13031048558: -0.003%
Covered Lines: 47083
Relevant Lines: 62790

💛 - Coveralls

@SiddharthBITS SiddharthBITS reopened this Jan 28, 2025
@SiddharthBITS SiddharthBITS changed the title [DO NOT MERGE] Version based connection reset using queries Version based connection reset using queries Jan 28, 2025
@SiddharthBITS SiddharthBITS force-pushed the Version_based_connection_reset_using_Queries branch from 372829d to 783806a Compare January 30, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants