-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version based connection reset using queries #3423
Open
SiddharthBITS
wants to merge
111
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
Choose a base branch
from
SiddharthBITS:Version_based_connection_reset_using_Queries
base: BABEL_5_X_DEV
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version based connection reset using queries #3423
SiddharthBITS
wants to merge
111
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
SiddharthBITS:Version_based_connection_reset_using_Queries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13061803500Details
💛 - Coveralls |
…sed_connection_reset_using_Queries
SiddharthBITS
changed the title
[DO NOT MERGE] Version based connection reset using queries
Version based connection reset using queries
Jan 28, 2025
Signed-off-by: SiddharthBITS <[email protected]>
…//github.com/SiddharthBITS/babelfish_extensions into Version_based_connection_reset_using_Queries
tanscorpio7
suggested changes
Jan 28, 2025
…sed_connection_reset_using_Queries
…//github.com/SiddharthBITS/babelfish_extensions into Version_based_connection_reset_using_Queries
tanscorpio7
approved these changes
Jan 30, 2025
SiddharthBITS
force-pushed
the
Version_based_connection_reset_using_Queries
branch
from
January 30, 2025 20:25
372829d
to
783806a
Compare
tanscorpio7
approved these changes
Jan 31, 2025
thephantomthief
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resetting connection after each test instead of closing for versions > 16.6. Also disabling pg_hint for tests that left it open, as the enabled pg_hint setting leaks into other tests when resetting connections.
We can expect 5-6 mins of improvements for version upgrade tests with base > 16.6 and dump-restore tests. For other version upgrade tests these improvements are around 2-3 mins.
Key changes:
Task:
Signed-off-by: Siddharth Sengar [email protected]
Check List
By submitting this pull request,
I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.