Set current db_id along with db_name for parallel workers #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumit Jaiswal <[email protected]>
tanscorpio7
approved these changes
Dec 30, 2024
shardgupta
approved these changes
Dec 30, 2024
shardgupta
merged commit 5af6776
into
babelfish-for-postgresql:BABEL_2_X_DEV
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit addresses the issue of empty result sets in queries joining with sys.db_id() or sys.db_name() in Enforced Parallel Query mode by setting the current_db_id in addition to current_db_name for parallel workers.
Signed-off-by: Sumit Jaiswal [email protected]
Issues Resolved
Task: BABEL-5504
Root cause
While we were communicating the logical database name to parallel workers and setting the current_db_name using logical database name (Ref: #2262), we failed to set current_db_id. This omission affected functions like sys.db_id() and sys.db_name(), resulting in empty result sets for queries involving these functions in parallel execution contexts.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.