Improve performance of sp_describe_undeclared_parameters (#1905)

[ahmed-shameem]

Description

sp_describe_undeclared_parameters is slow. The issue is reported here: #1317.

Initially, we used to create a query in C for every parameter passed as an argument to sp_describe_undeclared_parameters and then execute it. This was taking huge amount of time as it used JOINS among multiple views like sys.objects, sys.columns, sys.types T. In this commit, we have replaced the use of such views as much as possible with pg catalogs. This aids to the improvement in performance.

The changes are tested locally.

Performance improvements (All the times are in ms):
-------------- INSERT --------------

No of Params	Before	After
1	1109	298
2	1619	39
8	6061	562
10	7600	573
20	15498	967
30	23112	1170
40	31076	1563
50	39429	1745
60	49043	2628
70	55999	3318
80	65040	4381
90	73428	4978
100	83244	6072

Comparison on INSERT

-------------- UPDATE --------------

No of Params	Before	After
1	1681	177
2	2323	55
8	6919	556
10	8406	594
20	16280	976
30	23911	1195
40	31936	1581
50	40249	1765
60	49052	2606
70	57128	3318
80	65178	4365
90	73632	5028
100	83183	6102

Comparison on UPDATE

-------------- DELETE --------------

No of Params	Before	After
1	803	71
2	1507	37
8	6135	538
10	7710	575
20	15561	975
30	23361	1173
40	31125	1570
50	39824	1772
60	48933	2620
70	57075	3362
80	65444	4481
90	73762	5127
100	83991	6248

Comparison on DELETE

Approx Linear increment in execution time based on parameter size

QUERY PLAN AFTER MODIFICATION WITH EXPLICIT JOINS AND REMOVING UNNECESSARY CHECK ON t2.NAME:

1. INSERT: https://explain.dalibo.com/plan/dh97223b15e92h0d
2. UPDATE: https://explain.dalibo.com/plan/d28ec392d560b25c
3. DELETE: https://explain.dalibo.com/plan/348269ffgb6ae9g9

Task: BABEL-3705
Signed-off-by: Shameem Ahmed [email protected]

Test Scenarios Covered

• Use case based -

• Boundary conditions -

• Arbitrary inputs -

• Negative test cases -

• Minor version upgrade tests -

• Major version upgrade tests -

• Performance tests -

• Tooling impact -

• Client tests -

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.