Added case for indirect recusion

Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
babelfish-for-postgresql · Nov 6, 2023 · a25ba5b · a25ba5b
1 parent bed22b5
commit a25ba5b
Show file tree

Hide file tree

Showing 3 changed files with 133 additions and 0 deletions.
diff --git a/contrib/babelfishpg_tsql/src/hooks.c b/contrib/babelfishpg_tsql/src/hooks.c
@@ -733,6 +733,13 @@ pltsql_bbfViewHasInsteadofTrigger(Relation view, CmdType event)
 			{
 				return false; /** Direct recursive trigger case*/
 			}
+			else if (list_member_oid(triggerOids, current_tgoid))
+            {
+                /** Indirect recursive trigger case*/
+                ereport(ERROR,
+                        (errcode(ERRCODE_SYNTAX_ERROR),
+                         errmsg("Maximum stored procedure, function, trigger, or view nesting level exceeded (limit 32)")));
+            }
 		}
 	}
 

diff --git a/test/JDBC/expected/BABEL-2170-vu-verify.out b/test/JDBC/expected/BABEL-2170-vu-verify.out
@@ -513,6 +513,73 @@ int#!#varchar#!#varchar#!#numeric
 DROP TRIGGER IF EXISTS babel_2170_vu_employees_view_iot_update;
 GO
 
+
+
+-- Recursive Trigger test Indirect Recursion trigger 1 -> trigger 2 -> trigger 1
+CREATE TABLE babel_2170_vu_employees_rec
+(
+    EmployeeID      int NOT NULL,
+    EmployeeName    VARCHAR(50),
+    EmployeeAddress VARCHAR(50),
+    MonthSalary     NUMERIC(10, 2)
+)
+GO
+
+INSERT INTO babel_2170_vu_employees_rec VALUES(1, 'amber', '1st Street', '1000');
+INSERT INTO babel_2170_vu_employees_rec VALUES(2, 'angel', '1st Street', '2000');
+GO
+~~ROW COUNT: 1~~
+
+~~ROW COUNT: 1~~
+
+
+CREATE VIEW babel_2170_vu_employees_view_rec AS
+SELECT EmployeeID,
+       EmployeeName,
+       EmployeeAddress,
+       MonthSalary
+FROM babel_2170_vu_employees_rec
+WHERE EmployeeName LIKE 'a%';
+GO
+
+CREATE TRIGGER babel_2170_vu_employees_view_iot_rec ON babel_2170_vu_employees_view
+INSTEAD OF UPDATE
+AS
+BEGIN
+    UPDATE babel_2170_vu_employees_view_rec SET MonthSalary = MonthSalary +1 WHERE EmployeeID = 2;
+END
+GO
+
+CREATE TRIGGER babel_2170_vu_employees_view_iot_rec2 ON babel_2170_vu_employees_view_rec
+INSTEAD OF UPDATE
+AS
+BEGIN
+    UPDATE babel_2170_vu_employees_view SET MonthSalary = MonthSalary +1 WHERE EmployeeID = 2;
+END
+GO
+
+UPDATE babel_2170_vu_employees_view SET MonthSalary = MonthSalary +100 WHERE EmployeeID = 2;
+GO
+~~ERROR (Code: 33557097)~~
+
+~~ERROR (Message: Maximum stored procedure, function, trigger, or view nesting level exceeded (limit 32))~~
+
+
+
+-- UPDATE babel_2170_vu_employees_view_rec SET MonthSalary = MonthSalary +100 WHERE EmployeeID = 2;
+-- GO
+DROP TRIGGER IF EXISTS babel_2170_vu_employees_view_iot_rec;
+GO
+
+DROP TRIGGER IF EXISTS babel_2170_vu_employees_view_iot_rec2;
+GO
+
+DROP VIEW IF EXISTS babel_2170_vu_employees_view_rec;
+GO
+
+DROP TABLE IF EXISTS babel_2170_vu_employees_rec;
+GO
+
 -- test multi-db mode
 SELECT set_config('role', 'jdbc_user', false);
 GO

diff --git a/test/JDBC/input/triggers/BABEL-2170-vu-verify.sql b/test/JDBC/input/triggers/BABEL-2170-vu-verify.sql
@@ -274,6 +274,65 @@ GO
 DROP TRIGGER IF EXISTS babel_2170_vu_employees_view_iot_update;
 GO
 
+
+-- Recursive Trigger test Indirect Recursion trigger 1 -> trigger 2 -> trigger 1
+
+CREATE TABLE babel_2170_vu_employees_rec
+(
+    EmployeeID      int NOT NULL,
+    EmployeeName    VARCHAR(50),
+    EmployeeAddress VARCHAR(50),
+    MonthSalary     NUMERIC(10, 2)
+)
+GO
+
+INSERT INTO babel_2170_vu_employees_rec VALUES(1, 'amber', '1st Street', '1000');
+INSERT INTO babel_2170_vu_employees_rec VALUES(2, 'angel', '1st Street', '2000');
+GO
+
+CREATE VIEW babel_2170_vu_employees_view_rec AS
+SELECT EmployeeID,
+       EmployeeName,
+       EmployeeAddress,
+       MonthSalary
+FROM babel_2170_vu_employees_rec
+WHERE EmployeeName LIKE 'a%';
+GO
+
+CREATE TRIGGER babel_2170_vu_employees_view_iot_rec ON babel_2170_vu_employees_view
+INSTEAD OF UPDATE
+AS
+BEGIN
+    UPDATE babel_2170_vu_employees_view_rec SET MonthSalary = MonthSalary +1 WHERE EmployeeID = 2;
+END
+GO
+
+CREATE TRIGGER babel_2170_vu_employees_view_iot_rec2 ON babel_2170_vu_employees_view_rec
+INSTEAD OF UPDATE
+AS
+BEGIN
+    UPDATE babel_2170_vu_employees_view SET MonthSalary = MonthSalary +1 WHERE EmployeeID = 2;
+END
+GO
+
+UPDATE babel_2170_vu_employees_view SET MonthSalary = MonthSalary +100 WHERE EmployeeID = 2;
+GO
+
+-- UPDATE babel_2170_vu_employees_view_rec SET MonthSalary = MonthSalary +100 WHERE EmployeeID = 2;
+-- GO
+
+DROP TRIGGER IF EXISTS babel_2170_vu_employees_view_iot_rec;
+GO
+
+DROP TRIGGER IF EXISTS babel_2170_vu_employees_view_iot_rec2;
+GO
+
+DROP VIEW IF EXISTS babel_2170_vu_employees_view_rec;
+GO
+
+DROP TABLE IF EXISTS babel_2170_vu_employees_rec;
+GO
+
 -- test multi-db mode
 SELECT set_config('role', 'jdbc_user', false);
 GO