Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an SMS index/SMS deletion #57

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Getting an SMS index/SMS deletion #57

merged 1 commit into from
Nov 6, 2018

Conversation

malanovo
Copy link

Fix for issue #51, which was also affecting my environment. This modifies the ReceivedSms class so that there's access to the message index, which makes it possible to call things like deleteStoredSms without having to guess at the index.

Fix for issue #51, which was also affecting my environment.  This modifies the ReceivedSms class so that there's access to the message index, which makes it possible to call things like deleteStoredSms without having to guess at the index.
@coveralls
Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage decreased (-0.2%) to 89.712% when pulling 5bccf97 on malanovo:patch-1 into 0d04314 on babca:master.

@malanovo
Copy link
Author

Is there something weird with the Travis environment? All the tests pass when I run them in my environment, and the changes I submitted are pretty minor, so I can't see why Travis would have errored out like it did.

@babca
Copy link
Owner

babca commented Jan 17, 2018

First, thank for the PR! Second, I found a bug (code inconsistencies) caused from merging all the forks into this one and I tried to fix it back in November, but I got Travis CI broken. I need to revert last 3 commits in master and start again :-) I just haven't a free time to do this yet. I think I can revert the commits and merge your PR, and try to fix the bug later.

@malanovo
Copy link
Author

Thanks for the followup, I can understand the lack of free time. If there's anything I can do to help, please let me know.

@babca
Copy link
Owner

babca commented Nov 6, 2018

I rerun the tests and all passed. It was apparently a bug in Travis.

@babca babca changed the title Update modem.py Getting an SMS index/SMS deletion Nov 6, 2018
@babca babca merged commit 2afbf63 into babca:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants