Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #15
Returned timezone value is not a valid BCD number (0x2C). The timezone value should be close to +7 (+28 quarters, 0x28 in BCD). Currently I can see four interpretations:
According to the fact that the SMS was send from Jakarta (+7), negative values are (most probably) invalid (option 2 and 3).
Indonesia has timezones +7, +8 and +9, so 4th option is more probable that the 1st one (why local message should leave the country?).
This PR changes timezone calculation using 4th option and redefines unit test, which has problematic status PDU.