Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittest: modem calls #35

Merged
merged 3 commits into from
Mar 6, 2017
Merged

Unittest: modem calls #35

merged 3 commits into from
Mar 6, 2017

Conversation

tomchy
Copy link

@tomchy tomchy commented Mar 6, 2017

Trying to fix unit tests concerning calls.

Changes applied:

  • Command recognition responses inside fake modems
  • DTMF unittest adopted to iterative dial method
  • Call type resolution based on array field, not variable type (It was not sufficient due to the unicode/string switch and risky).

@babca babca changed the title Pr/unittest modem calls Unittest: modem calls Mar 6, 2017
@babca babca merged commit 068c6b4 into babca:master Mar 6, 2017
@tomchy tomchy deleted the pr/unittest-modem-calls branch March 8, 2017 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchy @babca