-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side preview visualizer renders shaders directly to threejs surfaces #345
Draft
xian
wants to merge
1,340
commits into
main
Choose a base branch
from
visualizer-control-direct-threejs-shader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create one, they're made as needed around an edit.
* PatchHolderEditor is replaced with a generic EditableManager. * Implement Editable to use it; PatchHolders and Controls are Editables. * Editables may have lots of EditorPanels, and they can be nested. * Clean up how changes are applied from the editor to the system. * Edit dialog has its own undo stack independent of the top-level undo stack.
* EditIntents may specify a different EditIntent to use after a change has been applied (e.g. after creating a new button and adding it to a group, edit that same button in place). * EditableManager's undo stack keeps track of both show and edit intent.
* Fix RemoteFs encoding to be symmetrical between client and server serializers. * More PubSub refactors for easier debug.
Overhaul editing dialog in design mode
* EditIntents may implement refreshEditIntent() e.g. if the Editable's id might change. * Fixed EditableManager.isModified() to compare to currently applied show so "Apply Changes" is properly enabled/disabled after Undo/Redo. * Created GenericPropertiesEditorPanel for editing arbitrary properties (e.g. title).
* Fix panel updates for Undo/Redo.
More EditableManager fixes
Remove old UvTranslator stuff
* Rename most uses of Surface to Fixture (except in Model).
Projection shader preview
* Fix moving unplaced controls into a layout. * Fix editing shader links. * List suggested controls in the unplaced controls list. * Shader editor panel doesn't scroll.
Design mode fixes
…e e.g. because they were removed from the shader code).
Fix crash when shader instance has weird port mappings
Nicer GLSL code display in simulator
…ons and button groups. Some UI cleanup.
* Split GlslParser out from GlslAnalyzer. * Slim down the Parser and Analyzer interfaces.
* Cache shader analysis via CachingToolchain, with a cache context for the editor. * Collect cache hit/miss and toolchain runtime stats.
Show shader problems in patch editor
Fix some bugs, support GLSL block comments
…the Extract Port refactor.
Prettier port extraction refactor in shader editor
No point hot-loading MosaicApp I think?
Add simple preview for moving head shaders
Patch overview sorts shaders by type, and shows type icon.
We'll eventually have a DirectRenderTarget used for direct-to-screen previews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.