[Test Case]: Alignment Infrastructure Curves #26

larswik · 2022-01-10T08:21:45Z

Summary

Outline of the content and tasks addressed by this pull request, dont forget to link the relevent issue(s)

Purpose

Please mark the relevent tasks that this pull request creates or updates:

Exchanges

Creation of new exchange
Documentation of exchange

Test Cases

General

CI updates
Repository documentation
Bug fixes

pjanck

Some suggestions, a lot is still to be defined.

E1a-ARSE/ALIN/Dataset/README.md

E1a-ARSE/ALIN/README.md

pjanck · 2022-01-10T12:37:03Z

E1a-ARSE/ALIN/README.md

+| TI Code                                  | Test Instruction Title  | Comments                                                     |
+| ---------------------------------------- | ----------------------- | ------------------------------------------------------------ |
+| [IFC4.3AbRV_E0_SSRD](../../E0-SSRD/SSRD) | Spatial Structures Road | Spatial structure for road incuding the dependencies (E0_SSSI, E0_MSTP) |
+


Do we have a georeferencing TI?

Thanks for commenting @pjanck! I have assumed that georeferencing is part of E0_MSTP which is mentioned in the table (and if you take a look into the TI dependency diagram from @AlexBrad1eyCT) on Miro https://miro.com/app/board/o9J_lkyDq70=/.
As you say, there's a lot still to be defined. My main issues are:

I have assumed straight line, circular arc, clothoid for horizontal and straight line, parabolic or circular arc for vertical. Is that all for a road alignment or are there other more obscure cases?

Is it enough to test straight, left turn, right turn in horizontal and straight up/down (connected with arcs) for vertical?

How to produce the actual test case? I looked at e.g. the alignment from MCON-2 but that does not contain clothoids. It would be nice to have a set case that uses all necessary segment types in all typical ways (left/right, up/down, transitions, ...).

For a road alignment, even parabolic arc is rare enough to raise the question: is it going to be mandatory for certification? Looking at validation criteria "For this test case to be considered passed all capabilities listed in this section shall be verified, with no exception" and "At least 1 instance of each entity listed in Itemised Roots is present in the file", I'd be very careful with what is included in the case (should be testing IFC export/import, not software capability in general). If it's not against any chosen certification strategy (?) might be reasonable to allow also "passed with exceptions (documented)", but if the validation criteria for a case really must be that draconian, I'd suggest making first a basic road alignment case with linear, circular arc and clothoid for horizontal; linear and circular arc for vertical.

During my "peak days", as a developer of road design software (this was a long time ago), the only vertical "curved curve" used was parabolic arc. Unfortunately, I didn't find anything regarding this in the RA. Might have missed it though. I wanted to mention both circular and parabolic until more info available

@larswik I'm not saying that parabolic arc wouldn't be valid vertical curve on roads and shouldn't be included in some test case. I'm just asking does it have to be supported as a mandatory requirement? If a software doesn't do parabolic arcs since their users do not use them they should still be able to get certified - I hope.

@JuhaHy good point of course! But it goes both ways right? I'm not sure how to organize these variations, but let's see.

Meta: I'd move this discussion to a separate issue for easier traceability. Searching for these comments in the future will be a pain, as well as a separate issue enables others to chime in as well. @larswik I'll copy the comments if that is ok with you.

georeferencing is part of E0_MSTP which is mentioned

That answers my question and resolves this conversation.

Co-authored-by: Stefan Jaud <[email protected]>

SergejMuhic · 2022-01-16T18:10:43Z

E1a-ARSE/ALIN/README.md

+
+The valid geometry segment types for horizontal are the following:
+
+- Arc


Would we just add parabolic arc here since the rest would be covered in E1?

I think that we could do it like that.

ping @pjanck

pjanck

So far so good!

According to discussions with Karin, Juha L and Juha H

…est-Instructions into feature/ALIN

pjanck

So far so good!

pjanck · 2022-02-17T10:59:04Z

E1a-ARSE/ALIN01/Dataset/README.md

+  - Line => Circular arc (cw) => Circular arc (ccw) => Line
+
+  - Line => Circular arc (ccw) => Circular arc (cw) => Line


Perhaps better to use "crest" and "sag"?

Should be fixed now.

pjanck · 2022-02-17T11:06:36Z

E1a-ARSE/ALIN01/README.md

+  - IfcSite
+  - IfcRoad


I'd list this in Spatial structure, separately from Model setup.

Should be fixed now.

pjanck

Reviewing while work is being done <3 I'll look at this later.

pjanck · 2022-02-17T11:13:50Z

E1a-ARSE/ALIN01/Dataset/README.md

+| A1   | IfcAlignment           | IfcLocalPlacement | None           |
+| AH1  | IfcAlignmentHorizontal | IfcLocalPlacement | None           |
+| AV1  | IfcAlignmentVertical   | IfcLocalPlacement | None           |


I'd not expect ObjectPlacement if there is no Representation.

Should be fixed now.

Used datasets from ALIN06

pjanck

I'm not done yet, but it's something :)

E1a-ARSE/ALIN01/Dataset/README.md

E1a-ARSE/ALIN01/Dataset/VerticalAlignmentParameters.csv

E1a-ARSE/ALIN01/README.md

…rameters

pjanck

Seems that my comments have been addressed.

The PR is still a draft. I suppose, more is going to be added?

@pjanck

According to comment from @pjanck

@pjanck

…yout According to comment from @pjanck

@pjanck

…ities section According to comment from @pjanck

Kept tables (dataset definition) in the Dataset/Readme

Update links

Draft readme for ALIN

cd78f89

larswik requested review from AlexBrad1eyCT, JuhaHy and SergejMuhic January 10, 2022 08:22

larswik self-assigned this Jan 10, 2022

larswik added documentation Improvements or additions to documentation test case issues & pull requests relating to test cases labels Jan 10, 2022

pjanck reviewed Jan 10, 2022

View reviewed changes

larswik and others added 3 commits January 10, 2022 13:51

Update E1a-ARSE/ALIN/README.md

2908391

Co-authored-by: Stefan Jaud <[email protected]>

Update E1a-ARSE/ALIN/README.md

7fce3c6

Co-authored-by: Stefan Jaud <[email protected]>

Update E1a-ARSE/ALIN/Dataset/README.md

481c164

Co-authored-by: Stefan Jaud <[email protected]>

SergejMuhic reviewed Jan 16, 2022

View reviewed changes

pjanck reviewed Jan 17, 2022

View reviewed changes

pjanck mentioned this pull request Jan 18, 2022

Mandatory entities for certification - discussion on example of road alignment #33

Open

larswik marked this pull request as draft January 24, 2022 15:13

larswik added 6 commits February 17, 2022 11:21

A little further on E1a-ALIN

ce03fae

According to discussions with Karin, Juha L and Juha H

Update README.md

1c5a724

Update README.md

c88d662

Merge branch 'develop' into feature/ALIN

31075a9

Update README.md

2f2490d

Merge branch 'feature/ALIN' of https://github.com/larswik/MVD-Infra-T…

95e0c30

…est-Instructions into feature/ALIN

pjanck reviewed Feb 17, 2022

View reviewed changes

larswik added 7 commits February 18, 2022 11:25

Added ALIN02 and ALIN04

8c3bcf5

Added ALIN05 and slightly corrected ALIN04 Readme

7e2b70d

Updated ALIN02 and ALIN05

beb0e53

First draft ALIN06

6b71fac

Included parameters for project global positioning

217b840

Introduced global positioning parameters

b598dc5

Updated ALIN03

e7f947a

Used datasets from ALIN06

larswik added 2 commits February 24, 2022 09:55

Introduced global positioning parameters

dbd70c6

Removed old files

2789c36

pjanck requested changes Mar 1, 2022

View reviewed changes

E1a-ARSE/ALIN01/Dataset/README.md Outdated Show resolved Hide resolved

E1a-ARSE/ALIN01/Dataset/VerticalAlignmentParameters.csv Outdated Show resolved Hide resolved

E1a-ARSE/ALIN01/README.md Outdated Show resolved Hide resolved

larswik added 2 commits March 1, 2022 14:19

Corrected according to comments from @pjanck

6f6c648

Updated geodetic datum (use EPSG) and corrected vertical alignment pa…

a673097

…rameters

pjanck reviewed Mar 1, 2022

View reviewed changes

larswik removed the request for review from AlexBrad1eyCT March 11, 2022 16:16

larswik marked this pull request as ready for review March 11, 2022 16:16

larswik added 18 commits March 15, 2022 08:29

No placement when no shape representation

53d6ee8

According to comment from @pjanck

"Crest"/"Sag" instead of "cw" and "ccw" in description of vertical la…

862c0d8

…yout According to comment from @pjanck

Moved IfcSite and IfcRoad to subsection "Spatial structure" under Ent…

750da5b

…ities section According to comment from @pjanck

Updated according to the ValidationCriteriaMaster

ee98d44

Kept tables (dataset definition) in the Dataset/Readme

Update README.md

ccb5659

Update README.md

b0c3f4a

Update links

Update README.md

3c57e01

Updates according to ValidationCriteriaMaster

41806d0

Update README.md

c5cb64d

Adding Spatial Containment and Spatial Decomposition and Cleaning up

5d16e98

Update README.md

b106edb

Update README.md

e35c0da

Updating links

f1c081b

Update README.md

82d1736

Update README.md

13e3e77

Updated according to ValidationCriteriaMaster

237aa8a

Fixed some links

2987130

Update README.md

5bd3bbc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Test Case]: Alignment Infrastructure Curves #26

[Test Case]: Alignment Infrastructure Curves #26

larswik commented Jan 10, 2022 •

edited

Loading

pjanck left a comment

pjanck Jan 10, 2022

larswik Jan 10, 2022 •

edited

Loading

JuhaHy Jan 10, 2022

larswik Jan 10, 2022

JuhaHy Jan 10, 2022

larswik Jan 11, 2022 •

edited

Loading

pjanck Jan 11, 2022

SergejMuhic Jan 16, 2022

larswik Jan 17, 2022

SergejMuhic Mar 14, 2022

pjanck left a comment

pjanck left a comment

pjanck Feb 17, 2022

larswik Mar 15, 2022

pjanck Feb 17, 2022

larswik Mar 15, 2022

pjanck left a comment

pjanck Feb 17, 2022

larswik Mar 15, 2022

pjanck left a comment

pjanck left a comment


		The valid geometry segment types for horizontal are the following:

		- Arc

		- Line => Circular arc (cw) => Circular arc (ccw) => Line

		- Line => Circular arc (ccw) => Circular arc (cw) => Line

[Test Case]: Alignment Infrastructure Curves #26

Are you sure you want to change the base?

[Test Case]: Alignment Infrastructure Curves #26

Conversation

larswik commented Jan 10, 2022 • edited Loading

Summary

Purpose

Exchanges

Test Cases

General

pjanck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larswik Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larswik Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjanck left a comment

Choose a reason for hiding this comment

pjanck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjanck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjanck left a comment

Choose a reason for hiding this comment

pjanck left a comment

Choose a reason for hiding this comment

larswik commented Jan 10, 2022 •

edited

Loading

larswik Jan 10, 2022 •

edited

Loading

larswik Jan 11, 2022 •

edited

Loading