Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS_GMN16_IfcTunnel_Sprint_1_1 #39

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/schema-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ on:
pull_request:
branches:
- main
<<<<<<< HEAD
=======
paths:
- "**.ifc"
>>>>>>> refs/remotes/origin/Development
Comment on lines +7 to +11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have merge conflicts' git's syntax committed here. Please revert such additions / delete such added lines. If you need help, we can have a quick call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me when you are free to have a call

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #67 - has this PR been superseded and can thus be closed? Perhaps we don't even need to resolve this problem.


jobs:
filter:
Expand All @@ -25,16 +28,26 @@ jobs:
with:
files: |
**/*.ifc
<<<<<<< HEAD
files_separator: ";"
=======
separator: "§"
>>>>>>> refs/remotes/origin/Development
- name: Logging
run: |
echo 'The following files were identified for checking:' >> $GITHUB_STEP_SUMMARY
echo '' >> $GITHUB_STEP_SUMMARY
<<<<<<< HEAD
IFS=';'; arrIN=(${{ steps.file_changes.outputs.all_changed_files }}); unset IFS;
for i in "${arrIN[@]}"; do
echo '- ' $i >> $GITHUB_STEP_SUMMARY
=======
IFS='§'
files="${{ steps.file_changes.outputs.all_changed_files }}"
deletedFiles=("${{ steps.file_changes.outputs.deleted_files }}")
for i in $files; do
[[ ! " ${deletedFiles[*]} " =~ " ${i} " ]] && echo '- ' $i >> $GITHUB_STEP_SUMMARY
>>>>>>> refs/remotes/origin/Development
done
echo '' >> $GITHUB_STEP_SUMMARY
check-ifc:
Expand All @@ -55,17 +68,27 @@ jobs:
id: downloadfile
run: |
mkdir download
<<<<<<< HEAD
$urlPath = "https://thc.lyforms.com/documents/thc/public/IFChecker.TunnelDeployment.zip"
$path = "${{ github.workspace }}\download\IFChecker.TunnelDeployment.zip"
=======
$urlPath = "https://thc.lyforms.com/documents/thc/public/IFChecker.TunnelDeployment"
$path = "${{ github.workspace }}\download\IFChecker.TunnelDeployment"
>>>>>>> refs/remotes/origin/Development
Invoke-WebRequest -URI $urlPath -OutFile $path
Expand-Archive $path -DestinationPath "${{ github.workspace }}\.github\workflows\"
- name: Check IFC files
id: checker
run: |
mkdir results
<<<<<<< HEAD
$cmnd = "${{ github.workspace }}\.github\workflows\IFChecker.TunnelDeployment.exe"
"${{ needs.filter.outputs.allchangedfiles }}".Split(";") | ForEach {
=======
$removed = "${{ needs.filter.outputs.removedfiles }}"
$cmnd = "${{ github.workspace }}\.github\workflows\IFChecker.TunnelDeployment.exe"
"${{ needs.filter.outputs.allchangedfiles }}".Split("§") | ForEach {
>>>>>>> refs/remotes/origin/Development
if( $removed -contains $_ ) {continue}
$filename = $("$_").Substring($("$_").LastIndexOf("/")+1)
if( [IO.Path]::GetExtension($filename) -ne ".ifc" ) {continue}
Expand Down
4 changes: 4 additions & 0 deletions FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@

**Where can I find the latest IFC schema?**

<<<<<<< HEAD
See [here](https://github.com/bSI-InfraRoom/IFC-Documentation-Tunnel/tree/main/4_4_0_0/general/EXPRESS).
=======
See [here](https://github.com/bSI-InfraRoom/IFC-Specification/actions/workflows/schema-generation-tunnel.yml).

Please click on the top-most element in the list of runs and download the artifact `IFC Schema`.

>>>>>>> refs/remotes/origin/Development

**Where can I find the latest IFC documentation?**

Expand Down
49 changes: 49 additions & 0 deletions PullRequest/3DS_GMN16_IfcTunnel_Sprint_1_2_Georef_A.ifc
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
ISO-10303-21;
HEADER;
FILE_DESCRIPTION(('ViewDefinition[ReferenceView]'),'2;1');

FILE_NAME('\\\\?\\C:\\Users\\GMN16\\Documents\\IFC\\bSI\\Sprint1.2\\3DS_GMN16_IfcTunnel_Sprint_1_2_Georef_A.ifc','2023-02-21T12:40:32+00:00',$,$,'3DEXPERIENCE PlatformUnofficial Packaging Version','3DEXPERIENCE Platform IFC4X4_17239AAA',$);

FILE_SCHEMA(('IFC4X4_17239AAA'));

ENDSEC;
DATA;
#5=IFCOWNERHISTORY(#3,#4,$,.NOTDEFINED.,$,$,$,1676983232) ;
#3=IFCPERSONANDORGANIZATION(#2,#1,$) ;
#2=IFCPERSON($,'FamilyName',$,$,$,$,$,$) ;
#1=IFCORGANIZATION($,'Name of Organization',$,$,$) ;
#4=IFCAPPLICATION(#1,'0.1','CATIA Data Exchange','CATIA') ;
#12=IFCCARTESIANPOINT((0.,0.,0.)) ;
#35=IFCCARTESIANPOINT((0.,0.,0.)) ;
#13=IFCDIRECTION((0.,0.,1.)) ;
#14=IFCDIRECTION((1.,0.,0.)) ;
#29=IFCDIRECTION((0.,1.,0.)) ;
#36=IFCDIRECTION((0.,0.,1.)) ;
#37=IFCDIRECTION((1.,0.,0.)) ;
#11=IFCAXIS2PLACEMENT3D(#12,#13,#14) ;
#34=IFCAXIS2PLACEMENT3D(#35,#36,#37) ;
#15=IFCGEOMETRICREPRESENTATIONCONTEXT('3D','Model',3,1.E-05,#11,#29) ;
#6=IFCUNITASSIGNMENT((#7,#8,#9,#10)) ;
#25=IFCELEMENTQUANTITY('09T4RvNOnWtNuap4Y0HlWa',#5,'Qto_SiteBaseQuantities',$,$,(#26,#27)) ;
#30=IFCLOCALPLACEMENT($,#34) ;
#33=IFCMAPCONVERSION(#15,#32,604177259.656,5362693120.45,0.,$,$,$) ;
#16=IFCPROJECT('09Qaa433D6tvuho1e78aP7',#5,'Project','Default Project',$,$,$,(#15),#6) ;
#32=IFCPROJECTEDCRS('EPSG:6893','WGS 84 / World Mercator + EGM2008 height',$,$,$,$,#7) ;
#18=IFCPROPERTYSET('09RNC0KViat_bJ7oelBjSx',#5,'Pset_SiteCommon',$,(#19,#20,#21,#22,#23)) ;
#19=IFCPROPERTYSINGLEVALUE('BuildableArea',$,IFCAREAMEASURE(0.),$) ;
#20=IFCPROPERTYSINGLEVALUE('SiteCoverageRatio',$,$,$) ;
#21=IFCPROPERTYSINGLEVALUE('FloorAreaRatio',$,$,$) ;
#22=IFCPROPERTYSINGLEVALUE('BuildingHeightLimit',$,$,$) ;
#23=IFCPROPERTYSINGLEVALUE('TotalArea',$,IFCAREAMEASURE(0.),$) ;
#27=IFCQUANTITYAREA('GrossArea',$,$,0.,$) ;
#26=IFCQUANTITYLENGTH('GrossPerimeter',$,$,0.,$) ;
#31=IFCRELAGGREGATES('09UnhoQHmSt1DrUcVHNXaE',#5,'IFCPROJECT_Container','Container for children of IFCPROJECT',#16,(#17)) ;
#24=IFCRELDEFINESBYPROPERTIES('09SHpz5yG2tZDyTZbNEcSm',#5,'Pset_SiteCommon',$,(#17),#18) ;
#28=IFCRELDEFINESBYPROPERTIES('09Tt3s8rG_tSXC8rYeKeaP',#5,'Qto_SiteBaseQuantities',$,(#17),#25) ;
#7=IFCSIUNIT(*,.LENGTHUNIT.,.MILLI.,.METRE.) ;
#8=IFCSIUNIT(*,.AREAUNIT.,$,.SQUARE_METRE.) ;
#9=IFCSIUNIT(*,.VOLUMEUNIT.,$,.CUBIC_METRE.) ;
#10=IFCSIUNIT(*,.PLANEANGLEUNIT.,$,.RADIAN.) ;
#17=IFCSITE('XWMFQSWkJVR4nZahhTlPpq',#5,'Site00000001_040A77B3-0000-4788-63F4BA1A00022E85',$,$,#30,$,$,.ELEMENT.,(43,31,27,699999),(5,25,38,700000),0.,$,$) ;
ENDSEC;
END-ISO-10303-21;
46 changes: 46 additions & 0 deletions PullRequest/Sprint01_GMN16_3DS.ifc
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
ISO-10303-21;
HEADER;
FILE_DESCRIPTION(('ViewDefinition[ReferenceView]'),'2;1');

FILE_NAME('\\\\?\\C:\\Users\\GMN16\\Documents\\IFC\\bSI\\Sprint10\\Site00000001_040A77B3-0000-4D00-63E3A53800021867 ---.000.ifc','2023-02-08T13:38:02+00:00',$,$,'3DEXPERIENCE PlatformUnofficial Packaging Version','3DEXPERIENCE Platform IFC4X4',$);

FILE_SCHEMA(('IFC4X4'));

ENDSEC;
DATA;
#5=IFCOWNERHISTORY(#3,#4,$,.NOTDEFINED.,$,$,$,1675863482) ;
#3=IFCPERSONANDORGANIZATION(#2,#1,$) ;
#2=IFCPERSON($,'FamilyName',$,$,$,$,$,$) ;
#1=IFCORGANIZATION($,'Name of Organization',$,$,$) ;
#4=IFCAPPLICATION(#1,'0.1','CATIA Data Exchange','CATIA') ;
#12=IFCCARTESIANPOINT((0.,0.,0.)) ;
#32=IFCCARTESIANPOINT((0.,0.,0.)) ;
#13=IFCDIRECTION((0.,0.,1.)) ;
#14=IFCDIRECTION((1.,0.,0.)) ;
#33=IFCDIRECTION((0.,0.,1.)) ;
#34=IFCDIRECTION((1.,0.,0.)) ;
#11=IFCAXIS2PLACEMENT3D(#12,#13,#14) ;
#31=IFCAXIS2PLACEMENT3D(#32,#33,#34) ;
#15=IFCGEOMETRICREPRESENTATIONCONTEXT($,'Model',3,1.E-05,#11,$) ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#15=IFCGEOMETRICREPRESENTATIONCONTEXT($,'Model',3,1.E-05,#11,$) ;
#15=IFCGEOMETRICREPRESENTATIONCONTEXT('3D','Model',3,1.E-05,#11,$) ;

#6=IFCUNITASSIGNMENT((#7,#8,#9,#10)) ;
#25=IFCELEMENTQUANTITY('0zl3657E1ccJu6J13SMEyb',#5,'Qto_SiteBaseQuantities',$,$,(#26,#27)) ;
#29=IFCLOCALPLACEMENT($,#31) ;
#16=IFCPROJECT('0ziZEGIuXCd5yDI69ZD3r8',#5,'Project','Default Project',$,$,$,(#15),#6) ;
#18=IFCPROPERTYSET('0zjLsC4L0gcwardt6BGCqy',#5,'Pset_SiteCommon',$,(#19,#20,#21,#22,#23)) ;
#19=IFCPROPERTYSINGLEVALUE('BuildableArea',$,IFCAREAMEASURE(0.),$) ;
#20=IFCPROPERTYSINGLEVALUE('SiteCoverageRatio',$,$,$) ;
#21=IFCPROPERTYSINGLEVALUE('FloorAreaRatio',$,$,$) ;
#22=IFCPROPERTYSINGLEVALUE('BuildingHeightLimit',$,$,$) ;
#23=IFCPROPERTYSINGLEVALUE('TotalArea',$,IFCAREAMEASURE(0.),$) ;
#27=IFCQUANTITYAREA('GrossArea',$,$,0.,$) ;
#26=IFCQUANTITYLENGTH('GrossPerimeter',$,$,0.,$) ;
#30=IFCRELAGGREGATES('0zmWL_A70YcDDM_YujSH0F',#5,'IFCPROJECT_Container','Container for children of IFCPROJECT',#16,(#17)) ;
#24=IFCRELDEFINESBYPROPERTIES('0zk0U9LnW8clHTzW2qJ5un',#5,'Pset_SiteCommon',$,(#17),#18) ;
#28=IFCRELDEFINESBYPROPERTIES('0zlrk1OgX4cOakeny5PO0Q',#5,'Qto_SiteBaseQuantities',$,(#17),#25) ;
#7=IFCSIUNIT(*,.LENGTHUNIT.,.MILLI.,.METRE.) ;
#8=IFCSIUNIT(*,.AREAUNIT.,$,.SQUARE_METRE.) ;
#9=IFCSIUNIT(*,.VOLUMEUNIT.,$,.CUBIC_METRE.) ;
#10=IFCSIUNIT(*,.PLANEANGLEUNIT.,$,.RADIAN.) ;
#17=IFCSITE('XWMFQSWkQuXuIrREJrl6hO',#5,'Site00000001_040A77B3-0000-4D00-63E3A53800021867',$,$,#29,$,$,.ELEMENT.,$,$,$,$,$) ;
ENDSEC;
END-ISO-10303-21;
4 changes: 4 additions & 0 deletions Recordings/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@

[Kick-off 2023-01-26](https://www.youtube.com/watch?v=VbaJULfcHz8)

<<<<<<< HEAD
[Kick-off 2023-01-27](https://www.youtube.com/watch?v=VbaJULfcHz8)
=======
[Sprint 1.1 support calls 2023-02-02](https://www.youtube.com/watch?v=HDqNItbsmAE)

[Sprint 1.1 support calls 2023-02-09](https://www.youtube.com/watch?v=HDqNItbsmAE)

[Sprint 1.2 KickOff 2023-02-09](https://www.youtube.com/watch?v=vsemMxGn60k)

[Sprint 1.2 support calls 2023-02-16](https://youtu.be/XFVki-hB5XI)
>>>>>>> refs/remotes/origin/Development
4 changes: 4 additions & 0 deletions files/project_team/example_sprint_1.1.ifc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ DATA;
#27 = IFCMONETARYUNIT('EUR');

/* ------- IfcGeometricRepresentationContext is the global context of the geometry ------------- */
<<<<<<< HEAD
#28 = IFCGEOMETRICREPRESENTATIONCONTEXT('Model', '3D', 3, 1.E-6, #29, #30);
=======
#28 = IFCGEOMETRICREPRESENTATIONCONTEXT('3D', 'Model', 3, 1.E-6, #29, #30);
>>>>>>> refs/remotes/origin/Development
#29 = IFCAXIS2PLACEMENT3D(#5, #4, #2);
#30 = IFCDIRECTION((0.,1.));

Expand Down
4 changes: 4 additions & 0 deletions files/project_team/larswik-test.ifc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ DATA;
#27 = IFCMONETARYUNIT('EUR');

/* ------- IfcGeometricRepresentationContext is the global context of the geometry ------------- */
<<<<<<< HEAD
#28 = IFCGEOMETRICREPRESENTATIONCONTEXT('Model', '3D', 3, 1.E-6, #29, #30);
=======
#28 = IFCGEOMETRICREPRESENTATIONCONTEXT('3D', 'Model', 3, 1.E-6, #29, #30);
>>>>>>> refs/remotes/origin/Development
#29 = IFCAXIS2PLACEMENT3D(#5, #4, #2);
#30 = IFCDIRECTION((0.,1.));

Expand Down
12 changes: 12 additions & 0 deletions sprints/sprint1_2.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ This sprint implements and tests `IfcProject` specific usages.

This sprint assumes you completed the following sprints:

<<<<<<< HEAD
- none.
=======
- [Sprint 1.1](./sprint1_1.md)
>>>>>>> refs/remotes/origin/Development


## Duration
Expand All @@ -21,6 +25,13 @@ This sprint assumes you completed the following sprints:

This sprint encompasses the following usages:

<<<<<<< HEAD
- [Project Global Positioning](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/project-global-positioning.htm)
- Project Global Positioning Geodetic
- Project Global Positioning Mapped
- [Classification Information](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/classification-association.htm)
- [Spatial Decomposition](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/spatial-decomposition.htm)
=======
- [Project Classification Information](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/project-classification-information.htm)
1. The `IfcProject` shall associate `IfcClassification` with non-empty `Source` and `Name` attributes (content of the attributes is irrelevant to the check at this stage)
- [Spatial Decomposition](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/spatial-decomposition.htm)
Expand Down Expand Up @@ -51,3 +62,4 @@ There shall be only one of these in the `ifc` dataset for the check to pass:
![grafik](https://user-images.githubusercontent.com/59165496/217642943-edfbf726-dbe4-4428-a596-7ce6357bc8bb.png)

Top path corresponds to `Georef_C`, diagonal path to `Georef_A` and bottom path to `Georef_B`. Sketch courtesy of Stefan Jaud.
>>>>>>> refs/remotes/origin/Development
15 changes: 15 additions & 0 deletions sprints/sprint1_3.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,22 @@ This sprint implements and tests `IfcProject` specific usages.

This sprint assumes you completed the following sprints:

<<<<<<< HEAD
- none.
=======
- [Sprint 1.1](./sprint1_1.md) and
- [Sprint 1.2](./sprint1_2.md).
>>>>>>> refs/remotes/origin/Development


## Duration

| Kick-off | Submission | Closure |
<<<<<<< HEAD
|-------------|-------------|-------------|
=======
| ----------- | ----------- | ----------- |
>>>>>>> refs/remotes/origin/Development
| 2023.02.23. | 2023.03.13. | 2023.03.16. |


Expand All @@ -23,6 +31,12 @@ This sprint assumes you completed the following sprints:
This sprint encompasses the following usages:

- [Project Document Information](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/project-document-information.htm)
<<<<<<< HEAD
- Project Dataset Information
- [Project Library Information](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/project-library-information.htm)
- [Project Type Definitions](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/project-type-definitions.htm)
- [Project Template Definitions](https://bsi-infraroom.github.io/IFC-Documentation-Tunnel/4_4_0_0/general/HTML/link/project-template-definitions.htm)
=======
- The `IfcProject` shall associate `IfcDocumentInformation` with;
- non-empty `Identification`, `Name` and `Location` attributes (content of the attributes is irrelevant to the check at this stage); as well as
- `ElectronicFormat` shall be `application/pdf` to denote the format of the "virtually" attached file; (you are not required to attach any such file for the test) and
Expand All @@ -47,3 +61,4 @@ This sprint encompasses the following usages:
- `Name` : 'DrillingDiameter'
- `TemplateType` : .P_SINGLEVALUE.
- `PrimaryMeasureType` : 'IfcPositiveLengthMeasure'
>>>>>>> refs/remotes/origin/Development