Update IFCTunnelDep3_Sys.ifc #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated file to fix some of the requested changes
AdamMackellar12d
requested review from
SergejMuhic,
larswik and
pjanck
as code owners
Fix up IfcQuantity measure types Add UsageType and PredefinedType to IfcTunnelPart Connect IfcAlignment directly to IfcProject Set measure type to IfcVolumetricFlowRateMeasure for IfcPropertyBoundedValue Clean up spatial structure heirarchy
Use only 1 IfcSite
Move water elements into IfcTunnel spatial structure
First draft of Sprint3_Geo
|
@AdamMackellar12d This one produces a problem. |
Remove IFCDIRECTION with 0 magnitude
Add in upto sprint 2.3 requirements
Fix Root spatial structure placementRelTo
Add GeoScienceFeature with VoxelGrid and associated IfcRealVoxelData and IfcIntegerVoxelData.
Aggregate 'Site 01' to IfcProject.
Separate out Geo_BookA and GeoBookB. Add GeoScienceModel/PHYSICALPROPERTYDISTIBUTIONMODEL into spatial structure under Site 01 and attach IfcGeoScienceFeature/PHYSICALPROPERTYDISTIBUTIONMODEL to it.
Change the relationship for IfcGeoScienceModel->IfcGeoScienceFeature from Spatial Structure to Decomposition.
Added in Pset_PipeSegmentTypeCommon for IfcPipeSegment entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #174
Updated IFCTunnelDep3_Sys.ifc to fix some of the issues in mentioned in PR#174