-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A part of Sprint 3.geo A for voxel #195
base: main
Are you sure you want to change the base?
Conversation
Updated the file |
@pjanck : Seems like a bug in the checker (object reference not set to an instance of an object). |
Commented out geophysical survey common property set
Alright, checked the file and there is a bunch of things wrong with it. The checker expects a certain completeness and since it is not there, we get a null value. The following should be corrected first as these mistakes are already very deep on schema level: The The last issue for |
@SergejMuhic, thank you for checking! I'll look into it and correct it. |
@SergejMuhic |
We are still dealing with serialization errors on voxel (see inline for further explanation):
No, you are right. This will be corrected in the reconciliation efforts. This issue does not influence a drop out of the check procedure however, so just ignore for now. |
@SergejMuhic |
Two issues:
should be
|
Updated borehole.ifc file. Added borehole.XML, which is the source of the data in borehole.ifc, and borehole.pdf, which is a borehole log generated based on the xml file.
Corrected errors that Stefan pointed out
Uploaded a new ifc file (tokyo/tokyo-sections.ifc) that contains a geological section. Currently, it uses IFC4x3 entities (i.e. building element proxy etc.) to view in BIM vision because the file is not rendered correctly in ifcviewer (please see screenshots below). @peterrdf Would be appreciated if you could check the file and look into why this happens. Thank you. |
Alright, the file is good. @peterrdf found a small bug. Here the screenshot: |
my bad indeed, the bug is fixed, viewer and library will be updated early next week (https://rdf.bg/product-list/ifc-engine/ifc-viewer/) |
Thank you, @peterrdf, @SergejMuhic for checking. I'll test our files with the updated version. |
File
Containing voxel