Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: ItemSet.dbc and updated Item_set_names sand Item_template to match new changes #1018

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

TheSCREWEDSoftware
Copy link
Contributor

Description

  • Created ItemSet.dbc (itemset_dbc.md)
  • Updated item_set_names (item_set_names.md)
  • Updated item_template (item_template.md)

Related Issue

Not aware

@pangolp new changes to EN files

Copy link
Member

@Kitzunu Kitzunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

| Field | Type | Attributes | Key | Null | Default | Extra | Comment |
| --------------------------------------- | ------- | ---------- | --- | ---- | ------- | ----- | ------- |
| [ID](#id) | INT | SIGNED | PRI | NO | 0 | | |
| [Name_Lang_enUS](#name_lang_enus) | VARCHAR | SIGNED | | YES | NULL | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI these links won't work. in a relative link to a header you cannot use special characters.

so a link to this header would be #namelangenus

## Name_Lang_enUS

(#name_lang_enus) -> Dont work
(#namelangenus) -> Work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUT to be clear. underscores in file names do work

@TheSCREWEDSoftware
Copy link
Contributor Author

Corrected

@TheSCREWEDSoftware
Copy link
Contributor Author

Ready to be reviewed.


The required skill rank the player needs to have to use this Item Set.

### DBC File Content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this. DBC is copyrighted by Blizzard. And we do not need to share the contents of it anyways as you can simply open a dbc editor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


<details>

<summary>Click to view</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the use for details

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While sure item_set_names is a small page, using <details> more often would save in a lot of page scroll.

From this

image

to

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why it could be nice. But I think it should be accessible at face value in a wiki

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When im back at pc I will remove it and make a push then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants