-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: ItemSet.dbc and updated Item_set_names sand Item_template to match new changes #1018
base: master
Are you sure you want to change the base?
New: ItemSet.dbc and updated Item_set_names sand Item_template to match new changes #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
docs/itemset_dbc.md
Outdated
| Field | Type | Attributes | Key | Null | Default | Extra | Comment | | ||
| --------------------------------------- | ------- | ---------- | --- | ---- | ------- | ----- | ------- | | ||
| [ID](#id) | INT | SIGNED | PRI | NO | 0 | | | | ||
| [Name_Lang_enUS](#name_lang_enus) | VARCHAR | SIGNED | | YES | NULL | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI these links won't work. in a relative link to a header you cannot use special characters.
so a link to this header would be #namelangenus
## Name_Lang_enUS
(#name_lang_enus) -> Dont work
(#namelangenus) -> Work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUT to be clear. underscores in file names do work
Corrected |
Ready to be reviewed. |
docs/itemset_dbc.md
Outdated
|
||
The required skill rank the player needs to have to use this Item Set. | ||
|
||
### DBC File Content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this. DBC is copyrighted by Blizzard. And we do not need to share the contents of it anyways as you can simply open a dbc editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/item_set_names.md
Outdated
|
||
<details> | ||
|
||
<summary>Click to view</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see the use for details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see why it could be nice. But I think it should be accessible at face value in a wiki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When im back at pc I will remove it and make a push then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Description
ItemSet.dbc
(itemset_dbc.md
)item_set_names
(item_set_names.md
)item_template
(item_template.md
)Related Issue
Not aware
@pangolp new changes to EN files