Refactor AuctionHouseBot.cpp + small bugfix #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
AuctionHouseBot::Buy
(make variable names more meaningful, simplify some if/else, move some checks to a little earlier when relevant, most importantly, properly remove auction from auctionPool:erase
takes an iterator argument when you want to delete an element at a specific position, giving it a uint32 will make it look for that value in the set).Issues Addressed:
Tests Performed:
How to Test the Changes: