-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core/WorldSession): implement mute manager #7386
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added config option `Mute.AddAfterLogin.Enable` for mute now or after login if the target offline - Removed old mute system (from `account` db table)
Kitzunu
reviewed
Aug 17, 2021
Kitzunu
reviewed
Aug 17, 2021
|
Thanks for testing |
Winfidonarleyan
added a commit
to WarheadCore/WarheadBand
that referenced
this pull request
Oct 2, 2021
Winfidonarleyan
added a commit
to WarheadCore/WarheadBand
that referenced
this pull request
Oct 2, 2021
ghost
removed
Script
labels
Oct 5, 2021
Azcobu
added
Script
Waiting to be Tested
DB
related to the SQL database
CORE
Related to the core
labels
Oct 6, 2021
after merge #8630 i continue this |
status @Winfidonarleyan |
Kitzunu
added
the
PR Abandoned
Original author stopped working on this PR. Feel free to take over.
label
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CORE
Related to the core
DB
related to the SQL database
PR Abandoned
Original author stopped working on this PR. Feel free to take over.
Script
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Mute.AddAfterLogin
for mute now or after login if the target offlineaccount
db table)Issues Addressed:
Tests Performed:
How to Test the Changes:
Known Issues and TODO List:
After removing the old mute system, will the original muted player be muted in the new system?
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.