Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/WorldSession): implement mute manager #7386

Closed
wants to merge 38 commits into from

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Aug 16, 2021

Changes Proposed:

  • Added config option Mute.AddAfterLogin for mute now or after login if the target offline
  • Removed old mute system (from account db table)
  • Added new functions for time format

Issues Addressed:

  • Closes

Tests Performed:

image
image

How to Test the Changes:

  1. Try add mute any player
  2. Check speak

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

- Added config option `Mute.AddAfterLogin.Enable` for mute now or after login if the target offline
- Removed old mute system (from `account` db table)
src/server/game/Accounts/MuteMgr.cpp Outdated Show resolved Hide resolved
src/server/game/Accounts/MuteMgr.cpp Outdated Show resolved Hide resolved
@IntelligentQuantum
Copy link
Member

@Winfidonarleyan

.mute Quantum 20 test
[Quantum]'s chat for 2312593072 minutes. Reason: test. <<< NEED FIX
.pinfo quantum
¦ Muted: (Reason: test, Time: 20m, Left 18m 6s, By: testtests)
Your chat has been muted for 20m. By: testtests. Reason: test.

@Winfidonarleyan
Copy link
Member Author

@Winfidonarleyan

.mute Quantum 20 test
[Quantum]'s chat for 2312593072 minutes. Reason: test. <<< NEED FIX
.pinfo quantum
¦ Muted: (Reason: test, Time: 20m, Left 18m 6s, By: testtests)
Your chat has been muted for 20m. By: testtests. Reason: test.

Thanks for testing

@Winfidonarleyan Winfidonarleyan marked this pull request as draft September 30, 2021 08:04
Winfidonarleyan added a commit to WarheadCore/WarheadBand that referenced this pull request Oct 2, 2021
Winfidonarleyan added a commit to WarheadCore/WarheadBand that referenced this pull request Oct 2, 2021
@ghost ghost removed Script labels Oct 5, 2021
@Azcobu Azcobu added Script Waiting to be Tested DB related to the SQL database CORE Related to the core labels Oct 6, 2021
@stoudtlr
Copy link
Contributor

After removing the old mute system, will the original muted player be muted in the new system?

Very good question! Thanks. Need test this, added to the tasks

muted player on clean build
image

db shows the mute
image

rebuild, run sql updates, and check db. notice new "active" field is set to "0"
image

test in game and chat is working
image

updated active field to 1 and relogged account. was now muted, but time wasn't right. showed only 5mins remaining for the mute.
image

@Winfidonarleyan
Copy link
Member Author

after merge #8630 i continue this

@Kitzunu
Copy link
Member

Kitzunu commented Apr 15, 2022

status @Winfidonarleyan

@Kitzunu Kitzunu added the PR Abandoned Original author stopped working on this PR. Feel free to take over. label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core DB related to the SQL database PR Abandoned Original author stopped working on this PR. Feel free to take over. Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants