feat(Module/Eluna): Add Support for Multistate

[iThorgrim]

Note

Implementation based on this PR.

📝 Description

This pull request introduces modifications to AzerothCore to ensure compatibility with the Multistate system in mod-eluna. The changes include:

• Adding MOD_ELUNA as a compilation flag in CMakeLists.txt.
• Enhancing WorldObject, Map, and World classes to support the Eluna scripting engine.
• Introducing GetEluna() methods to allow access to the Lua state.

These changes are a foundational step toward integrating advanced Multistate functionalities into mod-eluna, making future feature additions simpler and more maintainable.

🌟 Key Changes

1. CMake Configuration

Added -DMOD_ELUNA flag in modules/CMakeLists.txt to enable mod-eluna support at compile time when is detected.

2. Object and Map Integration

• Introduced GetEluna() method in WorldObject and Map classes.
• Ensured eluna is properly initialized when maps are loaded.
• Implemented cleanup logic for eluna instances when maps are destroyed.

3. World Class Enhancements

• Added a global Eluna* eluna instance to World.
• Provided a GetEluna() accessor method.

[heyitsbench]

Not a fan.

[iThorgrim]

Not a fan.

Thanks for your "feedback", I'd still like to know why? The work isn't finished yet, but maybe you can give me some feedback (hopefully with more arguments) 🦾

[heyitsbench]

Apologies for that blunt and unhelpful message, I'm tired. I do want Eluna to see multistate support, and I do applaud your work, but the part I am not a fan of is having compiler define checks for if Eluna is in use. Maybe it's just me, or maybe there's already code in AC like this, but I am of the opinion that a custom change/module like Eluna shouldn't be accommodated quite in this manner. Again, this is just my opinion, and I am not a significant vote on the matter. 😛

[iThorgrim]

The thing is, in my opinion, it’s not possible to do otherwise—at least, I haven’t found a way. Moreover, in the emulator, specifically in the module folder, there are already conditions specific to mod-eluna. I’ve also seen files in the emulator that are only useful if mod-eluna is used. ElunaScript.cpp, Object.h

I’m not saying this is the best solution, but for now, I’m the only one who has looked into the "issue", and I’ve asked for help. Ever since Eluna implemented multistate to port it to AzerothCore, no one has ever responded.

I agree that it clutters AzerothCore with very specific instructions, but if someone has a way to do it differently, I’m all ears! 😃

[kissingers]

In fact, there are same other modifications that match mod-Anticheat, which is good. However, mod-Anticheat is currently not well maintained and has many false positives. This is because the AZ side lacks sufficient similar matching for the module.
If someone can update the mod-Eluna to a more perfect state, but it requires a bit of cooperation from the AZ side, I personally think that would be great.

[zbhcn]

windows log:

[zbhcn]

Windows 日志：

Help me please , what's error is it?

[iThorgrim]

Windows 日志：

Help me please , what's error is it?

Your screen gives no indication of a possible error, there's nothing to help you understand the error or to help you, there's no usable information. The only visible thing seems to be the fact that it's impossible to copy/paste a folder, but it's impossible to know why ..

[Foereaper]

The define can be set through the cmake file of the module, no need to add it through the core cmake files. You'll definitely need the core file modifications though as shown, as well as for the core side storage (GetData/SetData) which you haven't added as part of this PR if you want that feature.

[sudlud]

I must say that I'm also not a fan of adding code sections to the core surrounded by module specific compile flags. We should find a better solution for this

[Foereaper]

There is no other solution to this. Eluna is not designed to be a module, it requires core functionality to work properly. The scope of a scripting engine is far beyond the current "module" script hook approach that it has been shoe-horned into the emulator as.

[zbhcn]

The thread safe issue still hasn't been resolved.this is my crash log:
unknown_worldserver.exe_[3-2_9-22-13].txt
@iThorgrim

[Winfidonarleyan]

std::unique_ptr