fix(Scripts/Naxxramas): Razuvious' Death Knight Understudy RP

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

1. implement Pause and Resume to WaypointMovementGenerator
   a. Pause() and Resume()
   changes from below are included

but did PR separately

• fix(Core/Movement): implement Pause and Resume to WaypointMovementGenerator #19176

2. Adds Out of Combat RP to Razuvious and his Death Knight Understudies.
   a. Add creature texts to Razuvious and Understudies. broadcast_ids are present in DB. Razuvious' "Pathetic...", picked Broadcast_ID "27865" as there are 3 exactly the same in the DB
   b. Razuvious sometimes he doesn't speak, but emotes
   c. Razuvious should emote "Exclamation" to all adds. Each add responds with a "Talk" and "Salute". Bottom left always speaks with 1 of 3 texts if spoken to
   d. Event repeats every 60-80s.
   e. Razuvious walks closely to the add and then emotes or speaks.
   f. Order of adds is uncertain. Random was easiest to implement

old PR

• fix(Scripts/Naxxramas): Razuvious' Death Knight Understudy RP  #18918

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

razu_rp.mp4

retail VOD: full 18 min recording https://www.youtube.com/watch?v=O7NDubkjbWg

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

razuvious_understudy_rp.mp4

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go c 128312
2. observe RP

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Kitzunu]

remove the waypoint stuff per 40b6366

[Kitzunu]

same here, we could use instance->GetCreature()

[Nyeriah]

Yes, here the storage can be used since there is only one razzuvious spawned

[sogladev]

tried in d3bf91c, failed to get Razuvious this way. The instancescript needs a refactor

[Kitzunu]

Hey Sogla! Please update as per review :)

[Nyeriah]

Add

 InstanceScript::OnCreatureCreate(creature);

To the OnCreatureCreate(Creature* creature) hook in the instance script and the storage will work, this is what you missed and why you couldn't get him to work

[sogladev]

Add

 InstanceScript::OnCreatureCreate(creature);

To the OnCreatureCreate(Creature* creature) hook in the instance script and the storage will work, this is what you missed and why you couldn't get him to work

works now, thanks!