Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore version constraints in setup.py's #2065

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Feb 27, 2024

Overview

This PR makes it so that setup.py's ignore the pinned versions in requirement.txt's. This addresses the frequent complaint of RV not being easy to use with other libraries because of the strong constraints on dependency versions. The pinned versions will now only be used for building the docker image.

If a constraint is crucial, it can be specified in the requirement_constraints dict in the respective setup.py (see the one in rastervision_pipeline for an example).

Additionally, the onnxruntime-gpu requirement has been removed, since it is hardware-dependent.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

mamba create --name rvtest python==3.11 -y
mamba activate rvtest
pip install -e ~/raster-vision/rastervision_pipeline/ ~/raster-vision/rastervision_aws_s3/ ~/raster-vision/rastervision_aws_batch/ ~/raster-vision/rastervision_core/ ~/raster-vision/rastervision_pytorch_learner/ ~/raster-vision/rastervision_pytorch_backend/ ~/raster-vision/rastervision_aws_sagemaker/

Fixes the onnxruntime-gpu part of #1867.

@AdeelH AdeelH marked this pull request as ready for review February 28, 2024 15:23
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.64%. Comparing base (22a794f) to head (d2cd66c).

Files Patch % Lines
...earner/rastervision/pytorch_learner/utils/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.02%     
==========================================
  Files         197      197              
  Lines        9763     9763              
==========================================
- Hits         8753     8752       -1     
- Misses       1010     1011       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdeelH AdeelH merged commit f4fdad0 into azavea:master Feb 28, 2024
2 checks passed
@AdeelH AdeelH deleted the req-constraints branch February 28, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant