Provisioning Fixes

[rajadain]

Overview

Updates to provisioning to get this project to setup. With virtualbox now being the default for this app, we would no longer need to specify CAC_APP_SHARED_FOLDER_TYPE=virtualbox before running vagrant commands on Windows and Linux.

Notes

By tying our NPM version to Ubuntu we make it less explicit, and potentially risk having it change when we do an Ubuntu upgrade. However, it was the easiest way to get a reliably working environment, and since the associated Ansible Role is old and unmaintained, I think it's alright.

Testing Instructions

• Check out this branch
• Remove your local node_modules folder

  rm -rf src/node_modules

• Delete and reprovision the app VM

  vagrant destroy -f app && vagrant up app

  • Ensure it provisions correctly
• Build the front-end

  ./scripts/serve-js-dev.sh

• Go to http://localhost:8024/
  • Ensure you see the running app

Checklist

• No gulp lint warnings
• No python lint warnings
• Python tests pass
• All TODOs have an accompanying issue link

Connects #XXX

[rachelekm]

Thank you for these fixes! I'm able to successfully provision and see the running app, but I'm having trouble accessing the django admin at localhost:8024/admin. I get a 301 status code and it will redirect to localhost:443/admin are you seeing something similar?

[rajadain]

I'm not exactly sure if this is the true explanation, but I believe this block:

cac-tripplanner/deployment/ansible/roles/cac-tripplanner.app/templates/nginx-default.j2

Lines 9 to 13 in 71a8966

	server {
	listen 80;
	server_name gophillygo.org www.gophillygo.org;
	return 301 https://$host$request_uri;
	}

Redirects http://localhost:8024/admin (which doesn't match any existing nginx configuration) to http://localhost:443/admin (via the return 301 line), which then fails because the front-end then goes to :443 rather than :8024 as the Vagrantfile mapping expects:

cac-tripplanner/Vagrantfile

Lines 138 to 139 in 71a8966

	# Web
	app.vm.network "forwarded_port", guest: 443, host: 8024

By making the trailing slash optional, we now allow http://localhost:8024/admin to behave identically to http://localhost:8024/admin/, both of which now correctly redirect.

Fixed in bd5b3d4.

Will require reprovisioning app. Ready for another look.

[rachelekm]

Thank you, @rajadain! I re-provisioned and the app as well as the admin page work as expected 👍 Thanks for this work, those fixes will really improve any future spin-up and dev experience!

[rajadain]

Before I merge this, I tried out the tests, and this one is failing:

cac-tripplanner/python/cac_tripplanner/cac_tripplanner/tests.py

Line 58 in 71a8966

def test_isochrone_partitioning(self):

Can you check on your end? It's possible I'm missing something in my local setup.

[rachelekm]

test_isochrone_partitioning

Strange! Luckily the tests are successful for me:

----------------------------------------------------------------------
Ran 36 tests in 4.424s

OK

I did some digging and looks like Katie bumped into this same issue in the past and it could be a machine-dependent failure.