Fix and enable code quality checks

ayltai · Sep 7, 2019 · 23fc519 · 23fc519
1 parent 14cd970
commit 23fc519
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 13 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -117,20 +117,17 @@ jobs:
       - *decode_gservices_key
       - run:
           name: Check code quality
-          command: ./gradlew check
+          command: ./gradlew check lint checkstyle dependencyCheckAnalyze
       - *save_cache
       - store_artifacts:
           path: app/build/reports/checkstyle
           destination: /check/
       - store_artifacts:
           path: app/build/reports/lint-results.html
-          destination: /check/
-      - store_artifacts:
-          path: app/build/reports/lint-results.xml
-          destination: /check/
+          destination: /check/lint-results.html
       - store_artifacts:
           path: app/build/reports/dependency-check-report.html
-          destination: /check/
+          destination: /check/dependency-check-report.html
 
   distribute:
     <<: *config

diff --git a/app/build.gradle b/app/build.gradle
@@ -150,9 +150,6 @@ dependencies {
     implementation ("androidx.lifecycle:lifecycle-extensions:$lifecycleVersion") {
         exclude group : 'com.android.support'
     }
-    annotationProcessor ("androidx.lifecycle:lifecycle-compiler:$lifecycleVersion") {
-        exclude group : 'com.android.support'
-    }
     implementation "androidx.lifecycle:lifecycle-common-java8:$lifecycleVersion"
 
     // Android Support libraries
@@ -267,7 +264,7 @@ configurations.all {
 //region Checkstyle configurations
 
 checkstyle {
-    toolVersion    '8.23'
+    toolVersion    '8.24'
     configFile     rootProject.file('./checkstyle.xml')
     ignoreFailures true
     showViolations true

diff --git a/app/src/main/java/com/github/ayltai/hknews/app/SearchFragment.java b/app/src/main/java/com/github/ayltai/hknews/app/SearchFragment.java
@@ -136,6 +136,7 @@ protected ListViewModel getListViewModel() {
                     break;
 
                 case Constants.SEARCH_TYPE_UNDEFINED:
+                default:
                     throw new IllegalArgumentException("Unrecognized search type");
             }
 

diff --git a/app/src/main/java/com/github/ayltai/hknews/util/DataBindingUtils.java b/app/src/main/java/com/github/ayltai/hknews/util/DataBindingUtils.java
@@ -12,7 +12,6 @@
 import android.widget.TextView;
 
 import androidx.annotation.DrawableRes;
-import androidx.annotation.IdRes;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.databinding.BindingAdapter;

diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
@@ -13,7 +13,5 @@
     <color name="cardBackground">@color/white</color>
     <color name="barBackground">@color/gray_50</color>
     <color name="placeholderTextColor">#40000000</color>
-    <color name="shadowStart">#00121212</color>
-    <color name="shadowEnd">#ff121212</color>
     <color name="menuItemBackground">#60000000</color>
 </resources>
-Original file line number
+Diff line change
@@ Expand Up / @@ -136,6 +136,7 @@ protected ListViewModel getListViewModel() { @@
                         break;
                     case Constants.SEARCH_TYPE_UNDEFINED:
+                    default:
                         throw new IllegalArgumentException("Unrecognized search type");
                 }
@@ Expand Down @@