setup for sqllite3 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep same version of bun.DB and dialects - Move (shared) SQL code into `datastore/sql` - update instances of postgres.New* to cfg.GetDatabase().New*
Closed
chore: run lint
chore: cleanup
oneEyedSunday
force-pushed
the
feat/sqllite3_support
branch
from
21f9503 to
7c23b42
Compare
adelowo
requested changes
Oct 13, 2024
adelowo
reviewed
Oct 13, 2024
adelowo
reviewed
Oct 13, 2024
|
aside these, I think I am happy to merge this. |
Hey man. I'll get to this in the next 24 |
requested changes added. |
thanks a lot for the work! Greatly appreciated! |
adelowo
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #33