Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changes return payload #14

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix: changes return payload #14

merged 4 commits into from
Mar 18, 2024

Conversation

tipusinghaw
Copy link
Contributor

What

  • Changed return object for create schema

@tipusinghaw
fix: changes return payload
7febfb1 
Signed-off-by: tipusinghaw <[email protected]>
@tipusinghaw tipusinghaw requested a review from sairanjit March 18, 2024 08:24
@tipusinghaw tipusinghaw self-assigned this Mar 18, 2024
@tipusinghaw
fix: format issye
e62af10 
Signed-off-by: tipusinghaw <[email protected]>
sairanjit
sairanjit approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sairanjit
sairanjit reviewed Mar 18, 2024
View reviewed changes
src/schema-manager.ts Outdated Show resolved Hide resolved
@sairanjit sairanjit self-requested a review March 18, 2024 08:29
@tipusinghaw
fix: resolve comments
b1f82bd 
Signed-off-by: tipusinghaw <[email protected]>
@tipusinghaw
fix: format
8b4d661 
Signed-off-by: tipusinghaw <[email protected]>
@sairanjit sairanjit merged commit 6c7b4d4 into main Mar 18, 2024
3 checks passed
@sairanjit sairanjit deleted the fix/create-schema-issue branch March 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairanjit sairanjit sairanjit approved these changes

Assignees

@tipusinghaw tipusinghaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tipusinghaw @sairanjit