-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add estimateMultihopFee function #336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nrsirapop
approved these changes
Nov 15, 2024
Looks good! as a follow up @npty, we should build this into the main |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://axelarnetwork.atlassian.net/browse/AXE-6367
This PR adds a function
estimateMultihopFee
to estimate gas fee for multiple-hops route.Please note: The devnet amplifier configuration URL is temporarily set to https://melted-fayth-nptytn-57e5d396.koyeb.app/chain/devnet-amplifier. This will be updated once the official URL becomes available.
Implementation
The function is a wrapper for a call to the endpoint
/gmp/estimateGasFeeForNHops
in axelarscan api. It validates given source chains and destination chains before making the api call.Usage
The
estimateMultihopFee
method provides flexible gas fee estimation for complex multi-hop transfers. This is particularly useful for:Blockers For Merging
devnet-amplifier
config with latest sui contract info (same as this one) deployed to s3. I've hardcoded it to point to the raw file in the github repo instead.