Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NEIRO token #137

Merged
merged 4 commits into from
Nov 1, 2024
Merged

feat: add NEIRO token #137

merged 4 commits into from
Nov 1, 2024

Conversation

trascaandrei
Copy link
Contributor

No description provided.

@benjamin852
Copy link
Contributor

The image should be your token's logo rather than the axelar logo. Also your salt value is empty why is that? It looks to me that your salt value should be 5A1D9D229D60019372FC72391EB26FBA30FE36EABA97BA172FD1716454DAC962. Just from checking the deployTokenManager tx logs

@benjamin852
Copy link
Contributor

Also missing coinGeckoId. See here for example

@trascaandrei
Copy link
Contributor Author

The image should be your token's logo rather than the axelar logo. Also your salt value is empty why is that? It looks to me that your salt value should be 5A1D9D229D60019372FC72391EB26FBA30FE36EABA97BA172FD1716454DAC962. Just from checking the deployTokenManager tx logs

Thanks for the review! I've done the requested changes

@Olanetsoft Olanetsoft merged commit 9ae643b into axelarnetwork:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olanetsoft Olanetsoft Olanetsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trascaandrei @benjamin852 @Olanetsoft