Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ITS): add chain name and token deploy salt and token sdk to ITS #95

Merged
merged 8 commits into from
Dec 4, 2024
Merged

feat(ITS): add chain name and token deploy salt and token sdk to ITS #95

merged 8 commits into from
Dec 4, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Dec 4, 2024 •
edited by jira bot
Loading

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (e63006a) to head (6722539).

Files with missing lines Patch % Lines
contracts/interchain-token-service/src/contract.rs 76.92% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   89.27%   89.23%   -0.04%     
==========================================
  Files          43       43              
  Lines        2900     2936      +36     
==========================================
+ Hits         2589     2620      +31     
- Misses        311      316       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahramy ahramy marked this pull request as ready for review December 4, 2024 18:44
@ahramy ahramy requested a review from a team as a code owner December 4, 2024 18:44
milapsheth
milapsheth approved these changes Dec 4, 2024
View reviewed changes
contracts/interchain-token-service/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/tests/test.rs Outdated Show resolved Hide resolved
@ahramy ahramy merged commit 017d421 into main Dec 4, 2024
5 checks passed
@ahramy ahramy deleted the feat/add-chain-name-and-token-sdk branch December 4, 2024 22:18
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahramy @codecov-commenter @milapsheth