Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(axelar-soroban-std): allow typed matching of emitted events #92

Merged
merged 17 commits into from
Dec 4, 2024
Merged

feat(axelar-soroban-std): allow typed matching of emitted events #92

merged 17 commits into from
Dec 4, 2024

Conversation

cgorenflo
Copy link
Contributor

@cgorenflo cgorenflo commented Nov 28, 2024 •
edited
Loading

@cgorenflo cgorenflo requested a review from a team as a code owner November 28, 2024 23:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.05882% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.27%. Comparing base (6440cf8) to head (b8365f5).

Files with missing lines Patch % Lines
packages/axelar-soroban-std/src/events.rs 85.52% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   89.47%   89.27%   -0.21%     
==========================================
  Files          42       43       +1     
  Lines        2842     2900      +58     
==========================================
+ Hits         2543     2589      +46     
- Misses        299      311      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

milapsheth
milapsheth reviewed Dec 3, 2024
View reviewed changes
packages/axelar-soroban-std/src/shared_interfaces.rs Show resolved Hide resolved
packages/axelar-soroban-std/src/shared_interfaces.rs Show resolved Hide resolved
packages/axelar-soroban-std/src/events.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std/src/events.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std/src/events.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std/src/events.rs Show resolved Hide resolved
@cgorenflo cgorenflo enabled auto-merge (squash) December 4, 2024 20:29
@cgorenflo cgorenflo merged commit 7a410ca into main Dec 4, 2024
5 checks passed
@cgorenflo cgorenflo deleted the event-helper branch December 4, 2024 20:31
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgorenflo @codecov-commenter @milapsheth