Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(upgrader): clean up the UpgraderInterface and simplify the contract #84

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

cgorenflo
Copy link
Contributor

No description provided.

@cgorenflo cgorenflo requested a review from a team as a code owner November 21, 2024 23:44
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.33%. Comparing base (6639369) to head (d917e2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/axelar-gateway/src/contract.rs 33.33% 4 Missing ⚠️
contracts/upgrader/src/contract.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   96.64%   96.33%   -0.31%     
==========================================
  Files          36       37       +1     
  Lines        2267     2076     -191     
==========================================
- Hits         2191     2000     -191     
  Misses         76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

contracts/upgrader/tests/atomic_upgrades.rs Outdated Show resolved Hide resolved
@cgorenflo cgorenflo enabled auto-merge (squash) November 22, 2024 16:44
@cgorenflo cgorenflo merged commit 8f298ff into main Nov 22, 2024
5 checks passed
@cgorenflo cgorenflo deleted the upgrader-refactor branch November 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants