feat(interchain-token-service,interchain-token): add contract constructor #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only has two variants which aren't used. leave commented out to indicate it should be used if an error is ever needed in the future (?)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 93.74% 94.16% +0.42%
==========================================
Files 33 32 -1
Lines 1598 1578 -20
==========================================
- Hits 1498 1486 -12
+ Misses 100 92 -8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
hydrobeam
changed the title
also drop succeeds (implies there's a failure, but there isn't)
milapsheth
reviewed
Nov 15, 2024
hydrobeam
changed the title
milapsheth
approved these changes
Nov 19, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://axelarnetwork.atlassian.net/browse/AXE-6583
Summary
similar to #69
only thing of note was that the
interchain-tokenContractErrortype only had two variants, both of which were removed. So I just commented it out (could just be deleted instead?)