Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interchain-token): update interchain token #71

Merged
merged 43 commits into from
Dec 3, 2024
Merged

feat(interchain-token): update interchain token #71

merged 43 commits into from
Dec 3, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Nov 15, 2024 •
edited by jira bot
Loading

@ahramy ahramy requested a review from a team as a code owner November 15, 2024 06:47
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.39073% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (442c42a) to head (32b59d2).

Files with missing lines Patch % Lines
contracts/interchain-token/src/contract.rs 91.03% 25 Missing ⚠️
contracts/interchain-token/src/interface.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   89.28%   89.44%   +0.15%     
==========================================
  Files          39       42       +3     
  Lines        2548     2842     +294     
==========================================
+ Hits         2275     2542     +267     
- Misses        273      300      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

milapsheth
milapsheth reviewed Nov 18, 2024
View reviewed changes
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/utils.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
ahramy
ahramy commented Nov 19, 2024
View reviewed changes
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/utils.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Show resolved Hide resolved
milapsheth
milapsheth reviewed Nov 27, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
contracts/interchain-token/src/storage_types.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/storage_types.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/storage_types.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/error.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/event.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
milapsheth
milapsheth reviewed Dec 2, 2024
View reviewed changes
packages/axelar-soroban-std/src/constants.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/lib.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
packages/axelar-soroban-std/src/error.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
milapsheth
milapsheth requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@milapsheth milapsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are looking pretty rough, please do another pass and ensure different flows are covered

contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
milapsheth
milapsheth approved these changes Dec 3, 2024
View reviewed changes
contracts/interchain-token/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/contract.rs Show resolved Hide resolved
packages/axelar-soroban-std/src/error.rs Outdated Show resolved Hide resolved
contracts/interchain-token/src/lib.rs Show resolved Hide resolved
contracts/interchain-token/src/storage_types.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
contracts/interchain-token/tests/test.rs Outdated Show resolved Hide resolved
@milapsheth milapsheth changed the title feat(its): update interchain token feat(interchain-token): update interchain token Dec 3, 2024
@ahramy ahramy merged commit 6440cf8 into main Dec 3, 2024
5 checks passed
@ahramy ahramy deleted the feat/interchain-token branch December 3, 2024 20:15
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttissNgo AttissNgo AttissNgo left review comments

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahramy @codecov-commenter @milapsheth @AttissNgo