feat(ITS): add ITS message ABI encoding/decoding support #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage ? 93.60%
=======================================
Files ? 33
Lines ? 2018
Branches ? 0
=======================================
Hits ? 1889
Misses ? 129
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ahramy
reviewed
Nov 13, 2024
ahramy
approved these changes
Nov 14, 2024
milapsheth
reviewed
Nov 14, 2024
- add ABI encoding/decoding for ITS messages - add ITS Hub message types
- replace match statements with one-liners where appropriate
- cargo sort workspace dependencies
- import std in root lib.rs #[cfg(test)] in order to use goldie assertions - add error handling to `try_into()` - add `into_vec` and `from_vec` helpers - rename soroban string and i128 conversion functions - remove redundant unit test
- change HubMessage to standard enum (not #[contracttype]) and refactor - simplify `to_i128` conversion function and use `ensure!` macro
AttissNgo
force-pushed
the
feat/its-message-abi-encoding
branch
from
5ff1615 to
f9e5ac8
Compare
- push re-built Cargo.lock after rebase
milapsheth
reviewed
Nov 18, 2024
- add checks for negative values for Uint<256,4> to i128 conversion - add test for invalid UTF-8 sequence when converting to Std String - add test for i128 overflow
- add test for invalid HubMessage
- remove #[contracttype] for all ITS message types - change decimals to u8
milapsheth
reviewed
Nov 19, 2024
milapsheth
approved these changes
Nov 19, 2024
- use i128::MAX directly in tests
cgorenflo
reviewed
Nov 19, 2024
- change abi_decode method to have single point of exit (no early return for error) - add u128 overflow test for `to_i128()`
- add improved error handling for string conversion (return Result instead of panic) - improved tests for string conversion
milapsheth
approved these changes
Nov 21, 2024
- remove unnecessary test - use assert_ok! in tests rather than unwrap - add test case for invalid hub message type
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-6065