feat(example): add interchain-token-service #149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbayindirli
force-pushed
the
feat/its-example
branch
from
d843463 to
a486502
Compare
milapsheth
reviewed
Jan 17, 2025
Comment on lines
+21
to
+26
| #[data] | ||
| pub token_id: BytesN<32>, | ||
| #[data] | ||
| pub token_address: Address, | ||
| #[data] | ||
| pub amount: i128, |
There was a problem hiding this comment.
Stellar has no limit on number or size of topics, so these 3 can go inside topics
There was a problem hiding this comment.
This was not a topic-related concern, but rather just a test of > 1 data field. It did result in a bug, which this PR patches (the macro was not properly passing multiple data field attributes to publish)
ahramy
reviewed
Jan 17, 2025
| env: Env, | ||
| gateway: Address, | ||
| gas_service: Address, | ||
| interchain_token_service: Address, |
There was a problem hiding this comment.
Note that this requires to change the deployment script: https://github.com/axelarnetwork/axelar-contract-deployments/blob/main/stellar/deploy-contract.js#L89-L93
There was a problem hiding this comment.
nbayindirli
force-pushed
the
feat/its-example
branch
from
5c50723 to
a4a1a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-7105