feat(interchain-token-service): add associated error types for ITS executable interface #142

cgorenflo · 2025-01-14T23:51:10Z

No description provided.

contracts/interchain-token-service/src/executable.rs

contracts/interchain-token-service/tests/executable.rs

# Conflicts: # Cargo.lock # contracts/interchain-token-service/tests/executable.rs # packages/axelar-soroban-std-derive/src/lib.rs

contracts/interchain-token-service/src/executable.rs

contracts/interchain-token-service/tests/executable.rs

# Conflicts: # contracts/interchain-token-service/src/contract.rs

codecov-commenter · 2025-01-20T16:42:49Z

Codecov Report

Attention: Patch coverage is 92.65734% with 21 lines in your changes missing coverage. Please review.

Project coverage is 94.94%. Comparing base (d9f465d) to head (34ec206).

Files with missing lines	Patch %	Lines
packages/axelar-std-derive/src/upgradable.rs	72.85%	19 Missing ⚠️
packages/axelar-std-derive/src/event.rs	98.36%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   94.89%   94.94%   +0.05%     
==========================================
  Files          53       58       +5     
  Lines        3390     3445      +55     
==========================================
+ Hits         3217     3271      +54     
- Misses        173      174       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/interchain-token-service/src/executable.rs

packages/axelar-std-derive/src/lib.rs

contracts/interchain-token-service/src/executable.rs

packages/axelar-std-derive/src/lib.rs

contracts/interchain-token-service/src/executable.rs

packages/axelar-std/src/interfaces/mod.rs

packages/axelar-std-derive/src/lib.rs

contracts/interchain-token-service/src/executable.rs

Co-authored-by: Milap Sheth <[email protected]>

…ated-error' into executable-its-trait-with-associated-error # Conflicts: # packages/axelar-std-derive/src/lib.rs

contracts/interchain-token-service/src/executable.rs

feat: add associated error types for ITS executable interface

afb0446

cgorenflo requested a review from a team as a code owner January 14, 2025 23:51

milapsheth reviewed Jan 15, 2025

View reviewed changes

contracts/interchain-token-service/src/executable.rs Outdated Show resolved Hide resolved

contracts/interchain-token-service/tests/executable.rs Outdated Show resolved Hide resolved

contracts/interchain-token-service/tests/executable.rs Show resolved Hide resolved

cgorenflo added 4 commits January 17, 2025 01:05

finalize design

8ca3101

rename

1592168

polished

1f6bfa7

Merge branch 'main' into executable-its-trait-with-associated-error

b98f466

# Conflicts: # Cargo.lock # contracts/interchain-token-service/tests/executable.rs # packages/axelar-soroban-std-derive/src/lib.rs

ahramy reviewed Jan 17, 2025

View reviewed changes

contracts/interchain-token-service/src/executable.rs Outdated Show resolved Hide resolved

contracts/interchain-token-service/tests/executable.rs Outdated Show resolved Hide resolved

cgorenflo added 4 commits January 17, 2025 19:13

address comments and merge main

e560c32

improve comment

9c6e6ca

Merge branch 'main' into executable-its-trait-with-associated-error

0fcc83f

# Conflicts: # contracts/interchain-token-service/src/contract.rs

resolve merge conflicts

dd23e5e

milapsheth reviewed Jan 20, 2025

View reviewed changes

contracts/interchain-token-service/src/executable.rs Outdated Show resolved Hide resolved

milapsheth changed the title ~~feat: add associated error types for ITS executable interface~~ feat(interchain-token-service): add associated error types for ITS executable interface Jan 20, 2025

cgorenflo and others added 9 commits January 20, 2025 23:33

Update packages/axelar-std/src/interfaces/mod.rs

a7ad39d

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/interchain-token-service/src/executable.rs

580dbe0

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/interchain-token-service/src/executable.rs

2d45cc7

Co-authored-by: Milap Sheth <[email protected]>

Update contracts/interchain-token-service/src/executable.rs

5d053bf

Co-authored-by: Milap Sheth <[email protected]>

Update packages/axelar-std-derive/src/lib.rs

5723de6

Co-authored-by: Milap Sheth <[email protected]>

addressing comments

71ce5c3

Merge remote-tracking branch 'origin/executable-its-trait-with-associ…

cce8ba6

…ated-error' into executable-its-trait-with-associated-error # Conflicts: # packages/axelar-std-derive/src/lib.rs

add interchain_token_service to public interface

a3922ac

Merge branch 'main' into executable-its-trait-with-associated-error

34ec206

milapsheth approved these changes Jan 20, 2025

View reviewed changes

contracts/interchain-token-service/src/executable.rs Show resolved Hide resolved

milapsheth merged commit 7615a1f into main Jan 20, 2025
5 checks passed

milapsheth deleted the executable-its-trait-with-associated-error branch January 20, 2025 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(interchain-token-service): add associated error types for ITS executable interface #142

feat(interchain-token-service): add associated error types for ITS executable interface #142

cgorenflo commented Jan 14, 2025

codecov-commenter commented Jan 20, 2025 •

edited

Loading

feat(interchain-token-service): add associated error types for ITS executable interface #142

feat(interchain-token-service): add associated error types for ITS executable interface #142

Conversation

cgorenflo commented Jan 14, 2025

codecov-commenter commented Jan 20, 2025 • edited Loading

Codecov Report

codecov-commenter commented Jan 20, 2025 •

edited

Loading