Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify event definition via IntoEvent derive macro #136

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: simplify event definition via IntoEvent derive macro #136

merged 5 commits into from
Jan 17, 2025

Conversation

nbayindirli
Copy link
Contributor

@nbayindirli nbayindirli commented Jan 13, 2025 •
edited by jira bot
Loading

@nbayindirli nbayindirli requested a review from a team as a code owner January 13, 2025 22:47
milapsheth
milapsheth reviewed Jan 14, 2025
View reviewed changes
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/Cargo.toml Outdated Show resolved Hide resolved
packages/axelar-soroban-std-derive/src/lib.rs Outdated Show resolved Hide resolved
@milapsheth milapsheth changed the title feat(axelar-soroban-std-derive): simplify Stellar event definition via IntoEvent derive macro feat(axelar-soroban-std-derive): simplify event definition via IntoEvent derive macro Jan 14, 2025
@nbayindirli nbayindirli marked this pull request as draft January 14, 2025 18:03
@nbayindirli nbayindirli marked this pull request as ready for review January 16, 2025 01:48
@nbayindirli nbayindirli force-pushed the feat/derive-into-event-macro branch from a1c4ec5 to 386504f Compare January 16, 2025 01:51
@nbayindirli nbayindirli force-pushed the feat/derive-into-event-macro branch from f0fc9c7 to 0e7ca8c Compare January 16, 2025 20:15
@nbayindirli nbayindirli force-pushed the feat/derive-into-event-macro branch from 88069ff to f99b09d Compare January 16, 2025 20:36
@nbayindirli nbayindirli changed the title feat(axelar-soroban-std-derive): simplify event definition via IntoEvent derive macro feat(stellar-axelar-std-derive): simplify event definition via IntoEvent derive macro Jan 16, 2025
milapsheth
milapsheth reviewed Jan 17, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
packages/axelar-std-derive/Cargo.toml Outdated Show resolved Hide resolved
packages/axelar-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-std-derive/src/lib.rs Outdated Show resolved Hide resolved
packages/axelar-std-derive/src/lib.rs Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/Cargo.toml Outdated Show resolved Hide resolved
@milapsheth milapsheth changed the title feat(stellar-axelar-std-derive): simplify event definition via IntoEvent derive macro feat: simplify event definition via IntoEvent derive macro Jan 17, 2025
@milapsheth milapsheth enabled auto-merge (squash) January 17, 2025 07:11
@milapsheth milapsheth merged commit 9052c78 into main Jan 17, 2025
5 checks passed
@milapsheth milapsheth deleted the feat/derive-into-event-macro branch January 17, 2025 07:11
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
@ahramy ahramy mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbayindirli @milapsheth