Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(axelar-gateway): use typed events #128

Merged
merged 11 commits into from
Jan 8, 2025
Merged

refactor(axelar-gateway): use typed events #128

merged 11 commits into from
Jan 8, 2025

Conversation

nbayindirli
Copy link
Contributor

@nbayindirli nbayindirli marked this pull request as ready for review January 6, 2025 20:15
@nbayindirli nbayindirli requested a review from a team as a code owner January 6, 2025 20:15
@nbayindirli nbayindirli force-pushed the chore/refactor-gateway-events branch from 783a3c3 to a5eaecc Compare January 6, 2025 20:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (7adc13d) to head (62d776b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   94.63%   94.67%   +0.03%     
==========================================
  Files          52       52              
  Lines        3130     3153      +23     
==========================================
+ Hits         2962     2985      +23     
  Misses        168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbayindirli nbayindirli changed the title feat(AG): refactor Stellar contract events to use typed events feat(AXG): refactor gateway contract events to use typed events Jan 6, 2025
ahramy
ahramy reviewed Jan 6, 2025
View reviewed changes
contracts/axelar-gateway/src/auth.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/contract.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/lib.rs Show resolved Hide resolved
contracts/axelar-gateway/src/testutils.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/tests/gateway.rs Outdated Show resolved Hide resolved
@ahramy
Copy link
Contributor

ahramy commented Jan 6, 2025

Please make sure lint test passes

milapsheth
milapsheth requested changes Jan 6, 2025
View reviewed changes
contracts/axelar-gateway/src/auth.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/auth.rs Show resolved Hide resolved
contracts/axelar-gateway/src/lib.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/testutils.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/testutils.rs Outdated Show resolved Hide resolved
@nbayindirli nbayindirli changed the title feat(AXG): refactor gateway contract events to use typed events refactor(axelar-gateway): use typed events Jan 6, 2025
milapsheth
milapsheth approved these changes Jan 8, 2025
View reviewed changes
contracts/axelar-gateway/src/contract.rs Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/event.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/testutils.rs Show resolved Hide resolved
contracts/axelar-gateway/src/testutils.rs Outdated Show resolved Hide resolved
@nbayindirli nbayindirli enabled auto-merge (squash) January 8, 2025 03:14
@nbayindirli nbayindirli merged commit 778ee8e into main Jan 8, 2025
5 checks passed
@nbayindirli nbayindirli deleted the chore/refactor-gateway-events branch January 8, 2025 03:20
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

@ahramy ahramy Awaiting requested review from ahramy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbayindirli @codecov-commenter @ahramy @milapsheth