Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ability to upload wasm artefacts based on release hash #100

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hydrobeam
Copy link
Contributor

@hydrobeam hydrobeam commented Dec 6, 2024

closes AXE-6843

the new workflow is mostly adapted from release.yaml

Test: https://github.com/axelarnetwork/axelar-cgp-soroban-testing/actions/runs/13063535201

@hydrobeam hydrobeam requested a review from a team as a code owner December 6, 2024 16:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (94632d8) to head (50db718).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files          69       69           
  Lines        3923     3923           
=======================================
  Hits         3809     3809           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/release-hash.yaml Outdated Show resolved Hide resolved
.github/workflows/reusable-build-upload.yaml Outdated Show resolved Hide resolved
.github/workflows/pre-release.yaml Show resolved Hide resolved
.github/workflows/pre-release.yaml Show resolved Hide resolved
.github/workflows/pre-release.yaml Show resolved Hide resolved
# Once a release is done for a package, we iterate on each of these packages and build its corresponding artifacts and upload them
strategy:
matrix:
releases: ${{ fromJson(needs.define-matrix.outputs.releases) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very inefficient, we're rebuilding each contract although they're all on the same commit. Separate the build and cloudflare upload into their own reusable workflows, so the build can be run once, and cloudflare push can be done for each contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants