Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow html min and max properties #2405

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ahoehn
Copy link

@ahoehn ahoehn commented Jan 30, 2023

Fixes #

Merge Checklist:

  • [x ] Code selfreview has been performed (Best Practices).
  • [x ] Tests are sufficient.
  • [x ] Documentation is up to date.
  • [x ] Changelog is up to date.
  • [x ] Typescript typings for properties are up to date.
  • [x ] Designers approved changes or no approval needed.
  • [ x] Dependencies to other components still work.

@markus-walther
Copy link
Contributor

Hello Adrian Höhn,

thanks for submitting a PR!

Can you please open an issue that clearly describes the problem that your PR desires to fix?
Then you can actually fill in the Fixes # ! I think that issue is a Feature request, so the label should be set that way.
Then, you might want to review lit-html template syntax here: https://lit.dev/docs/v1/lit-html/template-reference/#binding-types. Seems your min/max properties are using the syntax for Boolean attributes, which is probably not what you want.
Since you did not add any Playwright tests, you might want to add some to test your new feature - and only then check the checkbox above. Same for README.md documentation.

Thanks for working with us to get this into good shape.

Cheers, Markus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants