Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM release workflow #1474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sondavidb
Copy link
Contributor

@sondavidb sondavidb commented Feb 7, 2025

Issue #, if available:
Final part of #447

Description of changes:
While x86 release binaries were already automated, GitHub Actions does not have native ARM support so we have been manually creating those. This PR should allow for automatic ARM artifact release generation.

This was achieved by moving the build.yml setup into a new file setup.yml so that it can be reused between the Build and Release workflows.

With this, our release process should only be, creating a branch, adding the third-party licenses, and pushing the tag. From there the automation should do the rest.

Testing performed:
Created my own tag locally which created this dummy release (GitHub Actions run here).

I haven't tested publishing for multiple architectures yet, but that section is based on actions/download-artifact's README, so I think it should be right?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sondavidb sondavidb requested a review from a team as a code owner February 7, 2025 00:58
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 7, 2025
@sondavidb sondavidb force-pushed the add-arm-release-workflow branch 3 times, most recently from 6c5d21a to a32261a Compare February 7, 2025 01:10
Signed-off-by: David Son <[email protected]>
@sondavidb sondavidb force-pushed the add-arm-release-workflow branch from a32261a to 492c4a4 Compare February 7, 2025 01:13
@sondavidb
Copy link
Contributor Author

It's worth noting that with this artifact generation the glibc version used to generate the artifacts might differ. Probably not a big deal, but also probably worth noting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant